<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101908/">http://git.reviewboard.kde.org/r/101908/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101908/diff/5/?file=26770#file26770line73" style="color: black; font-weight: bold; text-decoration: underline;">creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LongLongPropertyWidgetItem::doubleValueChanged( double value )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">PropertyWidgetItem</span><span class="o">::</span><span class="n">valueChanged</span><span class="p">(</span> <span class="n">QVariant</span><span class="o">::</span><span class="n">fromValue</span><span class="o"><</span><span class="n">qlonglong</span><span class="o">></span><span class="p">(</span> <span class="n">value</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1)
a) QVariant::fromValue(1e100); will cause an undefined behaviour here with the overflow. This is not a performance critical part one condition check with a debug message would not hurt. I know it is unneccesary in this case since you explicitely set the range, but this slot is public now. Someone starts using it at some point for one reason and it can cause issues.
b) The other way is to make this slot private, if you do not use it outside of this class and you do not need to check it. In that case: private Q_SLOTS might help for now.
2) I personally like the qVariantFromValue macrousage since that provides the same functionality and also MSVC6 support (even though that is a bit old compiler).
Please do not change it though, it is just more like a comment, advise for future reference :), because the other classes work this way.</pre>
</div>
<br />
<p>- Laszlo</p>
<br />
<p>On July 12th, 2011, 2:10 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated July 12, 2011, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>creator/plugins/docks/propertiesdock/CMakeLists.txt <span style="color: grey">(05c5242)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101908/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>