<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101879/">http://git.reviewboard.kde.org/r/101879/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you can close this request according to the discussion happened this morning on IRC among us. Just for book keeping and for public, this does not address or/and solve the issue of hiding the private slots from the public. The "fe4b827" solved that issue in master.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On July 8th, 2011, 6:30 a.m., Shantanu Tushar Jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Shantanu Tushar Jha.</div>
<p style="color: grey;"><i>Updated July 8, 2011, 6:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I saw Arjen's comment on the start*ing signals Laszlo devised to call the Job slots when the provider was ready, I suddenly realised that its better to use QMetaObject::invokeMethod to call the slots, instead of emitting a signal whose sole purpose was to call the slot immediately. invokeMethod does all that in one line :)
(Also fixed few slot name hiccups, no idea when that happened)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested for fetchGames, works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>player/lib/gamedetaillistjob.cpp <span style="color: grey">(8b7d52c)</span></li>
<li>player/lib/models/gameitemsmodel.cpp <span style="color: grey">(49f77ee)</span></li>
<li>player/lib/serviceprovider.h <span style="color: grey">(1bf179d)</span></li>
<li>player/lib/serviceprovider.cpp <span style="color: grey">(97889b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101879/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>