<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101727/">http://git.reviewboard.kde.org/r/101727/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Shantanu Tushar Jha.</div>
<p style="color: grey;"><i>Updated June 22, 2011, 8:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made changes according to review comments. Tested, returns paths as expected (though with repeating /'s).
Please check if it produces proper paths on everyone's configuration. Thanks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When we were adding userDir functions to GluonCore::Global, for caching and flexibility purposes it was needed to add two variables. Keeping these static was quite a mess, and I and Arjen concluded that a Singleton is more suited for this kind of stuff.
As agreed on IRC, added a new class DirectoryProvider which has all the functions from GluonCore::Global except version because its not a directory function. Also, except the userDir function, other functions don't require an instance and can be called directly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall Gluon's players seem to function properly. The userData function returns correct paths for me, request everyone to check once for their configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/CMakeLists.txt <span style="color: grey">(8fd1dd0)</span></li>
<li>core/directoryprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/directoryprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/gluon_global.h.in <span style="color: grey">(792d65e)</span></li>
<li>core/gluonobjectfactory.cpp <span style="color: grey">(4501bed)</span></li>
<li>creator/plugins/docks/projectdock/projectdock.cpp <span style="color: grey">(e02ce53)</span></li>
<li>graphics/engine.cpp <span style="color: grey">(c4094b0)</span></li>
<li>graphics/examples/loadtexture/main.cpp <span style="color: grey">(229f9a4)</span></li>
<li>player/kde/mainwindow.cpp <span style="color: grey">(7071249)</span></li>
<li>player/lib/models/gameitemsmodel.cpp <span style="color: grey">(63075ed)</span></li>
<li>player/lib/ocsprovider.cpp <span style="color: grey">(1d5daa4)</span></li>
<li>player/qt/mainwindow.cpp <span style="color: grey">(0470e33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101727/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>