<div dir="ltr"><div>Hi,<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le sam. 14 mai 2022 à 18:10, Daniel Shahaf <<a href="mailto:danielsh@apache.org">danielsh@apache.org</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Johnny Jazeix wrote on Thu, May 12, 2022 at 22:19:31 +0200:<br>
> Le mer. 27 avr. 2022 à 23:09, Daniel Shahaf <<a href="mailto:danielsh@apache.org" target="_blank">danielsh@apache.org</a>> a écrit :<br>
> <br>
> > Johnny Jazeix wrote on Wed, Apr 27, 2022 at 21:52:02 +0200:<br>
> > > Hi,<br>
> > ><br>
> > > thanks for testing!<br>
> > ><br>
> > > Le mer. 27 avr. 2022 à 21:31, Daniel Shahaf <<a href="mailto:danielsh@apache.org" target="_blank">danielsh@apache.org</a>> a<br>
> > écrit :<br>
> > ><br>
> > > > the "X" / "V" graphic is to its right. That makes sense in LTR<br>
> > > > languages, but for RTL languages, where the "X" / "V" graphic of<br>
> > > > checkboxes is placed to the _right_ of the checkbox's text, the<br>
> > > > placement is misleading.<br>
> > > ><br>
> > > ><br>
> ><br>
> <br>
> I've added note to the task and I have fixed this one and the "About<br>
> dialog" too.<br>
<br>
Thanks!<br>
<br>
More below.<br>
<br>
> > > I've created <a href="https://phabricator.kde.org/T15482" rel="noreferrer" target="_blank">https://phabricator.kde.org/T15482</a> to write all the<br>
> > > inconsistencies we have for RTL language, can you take a look and add<br>
> > > other issues?<br>
> ><br>
> > I have an issue with the identity.k.o registration; I'll follow up on<br>
> > that separately. In the meantime, one more issue:<br>
> ><br>
> > - In Hebrew at least, the "About" screen aligns the first paragraph to<br>
> > the right (correctly) but the following paragraphs to the left<br>
> > (incorrectly). The order of letters and words is correct, but it's<br>
> > the left margin that aligns rather than the right one. Reversed<br>
> > example:<br>
> ><br>
> > Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Ut<br>
> > purus elit, vestibulum ut, placerat ac, adipiscing vitae, felis.<br>
> > Curabitur dictum gravida mauris. Nam arcu libero, nonummy eget,<br>
> > consectetuer id, vulputate a, magna.<br>
> ><br>
> > > For example, the authors in the help are written: "<name <<a href="http://email.com" rel="noreferrer" target="_blank">email.com</a>"<br>
> > > where we expect "name <email>". What is the correct form in Hebrew<br>
> > > for this?<br>
> ><br>
> > Good question. I suppose it should render as "name <email>", but in<br>
> > logical order, i.e., with name on the right.<br>
> ><br>
> > The po file writes the angle brackets as U+003C first and U+003E second,<br>
> > following rfc822's syntax as much as possible. However, these two<br>
> > characters get mirrored in RTL contexts:<br>
> ><br>
> > [[[<br>
> > % unicode 003c<br>
> > U+003C LESS-THAN SIGN<br>
> > UTF-8: 3c UTF-16BE: 003c Decimal: < Octal: \074<br>
> > <<br>
> > Category: Sm (Symbol, Math); East Asian width: Na (narrow)<br>
> > Unicode block: 0000..007F; Basic Latin<br>
> > Bidi: ON (Other Neutrals)<br>
> ><br>
> > Character is mirrored<br>
> > ]]]<br>
> ><br>
> > This would be why in your example you get two "<" marks. The one<br>
> > between "name" and "email" [in byte order] is a U+003C rendered<br>
> > mirrored, because it's preceded by an RTL character; the one after<br>
> > "email" [again in byte order] is a U+003E rendered normally, because<br>
> > it's preceded by an LTR character.<br>
> ><br>
> > I'm not sure how best to fix this. Normally I'd consider explicit<br>
> > Unicode directionality characters (the po file already uses literal<br>
> > U+200E, for instance), but this is a pseudo rfc822 context, and I'm not<br>
> > sure whether email clients would DTRT with embedded directionality<br>
> > characters, should the line be copy-pasted into them (e.g., by<br>
> > a translator). Perhaps we could sidestep the problem entirely by using<br>
> > <a href="mailto:…">[translator's name in Hebrew]</a> tags? Or by moving<br>
> > the email addresses to a po comment; they _already_ aren't rendered (as<br>
> > of v2.4 on Linux).<br>
> ><br>
> ><br>
> For this one, I still don't have any fix. The mails are displayed but non<br>
> clickable<br>
<br>
Ah, so we have been talking past each other.<br>
<br>
I thought you were referring to the names and email addresses in the<br>
"translator-credits" line in core/DialogAbout.qml, and answered<br>
accordingly. However, I see now you are referring to the names and<br>
addresses of activity authors, as given by "author" in ActivityInfo.qml<br>
and shown in an activity's help page.<br>
<br>
Translators names are given in the local language whereas activity<br>
authors' names are given in English.<br>
<br>
> (no link in the application is clickable at all because we don't want<br>
> children to wander on Internet :)).<br>
<br>
Well, that's security by obscurity, isn't it? :-)<br>
<br></blockquote><div><br></div><div>Mmmmmh, it's more that we want the children to focus on the activities :-).<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> They are also not in the .po file because it does not seem to make<br>
> sense to translate people names/emails (maybe I'm wrong)?<br>
<br>
I don't know.<br>
<br>
Personally, I'm fine seeing the names untranslated because if I wanted<br>
to do anything with the names (e.g., to write to the person, or to look<br>
up what else they have worked on), I'd need to know the names in their<br>
untranslated form.<br>
<br>
Another case where it would be useful to translate authors' names is if<br>
the "author" string includes words or particles other than names. For<br>
instance, in this string:<br>
<br>
land_safe/ActivityInfo.qml:13: author: "Matilda Bernard (Gtk+), Holger Kaelberer (Qt Quick)"<br>
<br>
both the name "Qt Quick" and the comma are potentially translatable.<br>
(E.g., running Arabic text uses U+060C ARABIC COMMA in preference to<br>
the ASCII comma, but I don't know which comma ar.po would use in this<br>
context if it had the option.)<br>
<br>
> We can reverse the name/email programmably but there is still the<br>
> issue.<br>
> We added/fixed the display of the email contributor thanks to<br>
> <a href="https://bugs.kde.org/show_bug.cgi?id=349111" rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.cgi?id=349111</a> and if I'm not wrong, we<br>
> already received contributions/feedbacks thanks to it so it would be nice<br>
> to keep it.<br>
<br>
In the case of authors' names I think making the "Name <email>" part<br>
explicitly LTR even when localized to an RTL language would be<br>
appropriate. This would be useful to all RTL languages and would be<br>
a no-op for LTR languages, so perhaps this? —<br>
<br>
[[[<br>
diff --git a/src/core/DialogHelp.qml b/src/core/DialogHelp.qml<br>
index 7155590..ba3dbbb 100644<br>
--- a/src/core/DialogHelp.qml<br>
+++ b/src/core/DialogHelp.qml<br>
@@ -46,7 +46,8 @@ DialogBackground {<br>
var contentText = "<b>" + activityInfo.description + "</b>"<br>
contentText += "<br/><br/>"<br>
if(activityInfo.author) {<br>
- contentText += "<b>" + qsTr("Author:") + " </b>" + activityInfo.author<br>
+ contentText += "<b>" + qsTr("Author:") + " </b>"<br>
+ contentText += "<span dir=\"ltr\">" + activityInfo.author + "</span>"<br>
contentText += "<br/><br/>"<br>
}<br>
if(activityInfo.prerequisite) {<br>
]]]<br>
<br>
I don't have a build environment to test that, sorry. However, it<br>
should result in author names being rendered as "Name <email>" in both<br>
RTL and LTR languages, with correct angle brackets.<br>
<br></blockquote><div><br></div><div>I didn't replied earlier because I tried multiple things without success. According to <a href="https://doc.qt.io/qt-5/richtext-html-subset.html#block-attributes">https://doc.qt.io/qt-5/richtext-html-subset.html#block-attributes</a>, span do not have<br></div><div>the "dir" attribute. I tried with <p> or <hx>, but the author is then written in the next line, not directly following the "Author:".<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Cheers,<br>
<br>
Daniel<br>
<br>
> Cheers,<br>
> <br>
> Johnny<br>
> <br>
> <br>
> > Cheers,<br>
> ><br>
> > Daniel<br>
> ><br>
> > [1]<br>
> > <a href="https://en.wikipedia.org/wiki/Bidirectional_text#Table_of_possible_BiDi_character_types" rel="noreferrer" target="_blank">https://en.wikipedia.org/wiki/Bidirectional_text#Table_of_possible_BiDi_character_types</a><br>
> ><br>
> ><br>
</blockquote></div></div>