<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
Your diff is incomplete, it only contains the last commit not the
whole activity so we can't really make comments on it.<br>
<br>
I'm doing some of them here:<br>
<br>
* it misses a default value for the configuration. If you remove
it from the config file (~/.config/gcompris/gcompris-qt.conf) and
start again GCompris, when you go on the configuration, the box
will be empty.<br>
<br>
* Also, the save/load of the configuration does not work. As you
can see in the log: save configuration for: "" instead of save
configuration for: "multiplication_tables". It's because you
didn't initialize the dialogActivityConfig in
Component.onCompleted. You can check on other activities using
configuration (traffic).<br>
<br>
* Is it useful to have 2 different buttons "Start" and "Finish" or
can we only have one?<br>
<br>
* For the "school" mode, we can put as many questions as we want.
It's not handled properly in the activity then (questions override
the different buttons for example).<br>
<br>
* shouldn't we change the name of the modes? "School mode" and
"Normal mode" are not really explicit.<br>
<br>
Johnny<br>
<br>
On 03/10/17 00:34, Emmanuel Charruau wrote:<br>
</div>
<blockquote
cite="mid:CA+jbWcHwXGes3dWNmN7xiWOvpnQ9CFXVBrYuHQP=z4V5bXVDTg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>Hi Nitish,<br>
<br>
</div>
Just played it without looking at the code.<br>
</div>
Very nice to play, it looks like I imagined it.<br>
<br>
</div>
Two remarks at the moment.<br>
</div>
In school mode, the cards should be shuffled to avoid
pupils to learn the positions of the answers. I saw
them last year learning by heart the sequenced
answers. I shuffled the questions and a few pupils
where totally lost.<br>
</div>
When choosing the mode, the presentation (school mode
select your mode) lost me. It could be more obvious.<br>
<br>
</div>
Next step for me will be to look at the code to see if we
can proposer long sentences.<br>
<br>
</div>
Great job :)<br>
<br>
</div>
Thanks<br>
<br>
</div>
Emmanuel<br>
<div>
<div>
<div>
<div>
<div> <br>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-03-09 5:45 GMT+01:00 nitish
chauhan <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:nitish.nc18@gmail.com" target="_blank">nitish.nc18@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi,<br>
the current status of the activity can be tracked here :-<br>
<br>
<div><b>latest commit :-</b> <a moz-do-not-send="true"
href="https://cgit.kde.org/gcompris.git/commit/?h=sok_nitishc_multiplicationtables&id=8bb92a326f3c805943377f2aa50b7bce0b69b9e1"
target="_blank">https://cgit.kde.org/<wbr>gcompris.git/commit/?h=sok_<wbr>nitishc_multiplicationtables&<wbr>id=<wbr>8bb92a326f3c805943377f2aa50b7b<wbr>ce0b69b9e1</a></div>
<div><b><br>
</b></div>
<div><b>Code review phabricator :-</b> <br>
</div>
<div><a moz-do-not-send="true"
href="https://phabricator.kde.org/D4982"
target="_blank">https://phabricator.kde.org/<wbr>D4982</a><br>
</div>
<div><br>
</div>
<div>Task done :-</div>
<div>1.) Both normal & school mode completed<br>
2,) Minor bug fixes & code refracting.<br>
<br>
</div>
<div>please share your feedback & review.<br>
<br>
regards,<br>
Nitish</div>
<div><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>