Chess board H column label

[Johnny Jazeix]

Thank you!

I'm checking it and committing it.

Cheers,

Johnny

Le dim. 28 août 2022 à 19:27, Daniel Shahaf <d.s at daniel.shahaf.name> a
écrit :

> In chess_2players, when the board is rotated so black is down, the label
> of column H is incorrect.
>
> Seen on 2.4 on android and linux.
>
> Presumed fix:
>
> [[[
> diff --git a/src/activities/chess/Chess.qml
> b/src/activities/chess/Chess.qml
> index cadc3a4d..d76d3664 100644
> --- a/src/activities/chess/Chess.qml
> +++ b/src/activities/chess/Chess.qml
> @@ -409,7 +409,7 @@ ActivityBase {
>                  Behavior on opacity { PropertyAnimation { easing.type:
> Easing.InOutQuad; duration: 500} }
>                  Repeater {
>                      id: lettersA
> -                    model: chessboard.rotation == 0 ? ["F", "G", "F",
> "E", "D", "C", "B", "A"] : ["A", "B", "C", "D", "E", "F", "G", "H"]
> +                    model: chessboard.rotation == 0 ? ["H", "G", "F",
> "E", "D", "C", "B", "A"] : ["A", "B", "C", "D", "E", "F", "G", "H"]
>                      GCText {
>                          x: items.cellSize * (index % 8) +
> (items.cellSize/2-width/2)
>                          y: items.cellSize * Math.floor(index / 8)
> ]]]
>
> (Untested because I don't have a build environment yet.)
>
> Found by a young friend of mine :-)
>
> Cheers,
>
> Daniel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gcompris-devel/attachments/20220828/da06b87b/attachment.htm>