[FreeNX-kNX] freenx-client 0.9 feedback

[Johnny Hughes]

Seb James wrote:
> On Thu, 2008-04-10 at 12:08 +0200, Dirk Mueller wrote:
>> Hi, 
>>
>> some feedback from trying to build freenx-client 0.9 release:
> 
> Thanks for the feedback Dirk!
> 
>> a) it does not build with gcc 4.3. see attached patch
>>
>> b) qtnx can still not install itself. see other attached patch
>>
>> c) as qtnx needs pkgconfig to resolve the libnxcl, which is built in the other 
>> subdir, I think it would cause less pain for the packagers of those two sub 
>> directory would be separated in different tarballs. They don't share a common 
>> build system anyway. 
>>
>> d) the source code claims to be GPL v2+. GPL however requires to ship a GPL 
>> license in a file named COPYING as part of the package. this doesn't seem to 
>> be the case. Please clarify the actual license of the code. Also, list of 
>> authors etc is missing as well, but I fetched them from the actual source 
>> file.
> 
> An oversight. The COPYING file should be added.
> 
>> e) the autoconf/automake requires of libnxcl are extremely high, while it 
>> seems to build just fine with older version of autotools, once those are 
>> fixed. Is there a reason for that? this is a problem for older distributions.
> 
> These were set to whatever autotools I was working with at the time -
> possible Ubuntu 6.06. I would have not objections to reducing these to
> the minimum that would work.

I lowered them to this for CentOS5:

AC_PREREQ(2.59)
AM_INIT_AUTOMAKE([1.9.6 foreign])

Everything seems to work OK at this level for me on i386 and x86_64 arches.

Thanks,
Johnny Hughes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/freenx-knx/attachments/20080412/0061df72/attachment.sig>