<table><tr><td style="">drosca requested changes to this revision.<br />drosca added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27440">View Revision</a></tr></table><br /><div><div><p>I don't really like, there is ton of duplicated code. Also coding style is wrong.</p>
<p>Can you change it so that you only touch what you need to touch? As far as I can see the only change you made is that instead of <tt style="background: #ebebeb; font-size: 13px;">input.type</tt> it looks for <tt style="background: #ebebeb; font-size: 13px;">input.placeholder</tt>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27440">https://phabricator.kde.org/D27440</a></div></div><br /><div><strong>To: </strong>puneethchanda, SGOrava, drosca<br /><strong>Cc: </strong>falkon, Falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo<br /></div>