<table><tr><td style="">drosca requested changes to this revision.<br />drosca added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19804">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111226">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">#</span> <span class="n">Falkon<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">Web</span></span><span class="bright"> </span><span class="n"><span class="bright">Browser</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">#</span> <span class="n">Falkon</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">__Falkon__</span> <span class="p">(</span><span class="n">formerly</span> <span class="n">QupZilla</span><span class="p">)</span> <span style="color: #aa4000">is</span> <span class="n">a</span> <span class="n">free</span> <span class="n">and</span> <span class="n">open</span><span class="p">-</span><span class="n">source</span> <span class="n">web</span> <span class="n">browser</span><span class="p">.</span> <span class="n">It</span> <span style="color: #aa4000">is</span> <span class="n">built</span> <span class="n">on</span> <span class="n">the</span> <span class="n">Qt</span> <span class="n">WebEngine</span> <span class="n">which</span> <span style="color: #aa4000">is</span> <span class="n">a</span> <span class="n">wrapper</span> <span style="color: #aa4000">for</span> <span class="n">the</span> <span class="n">Chromium</span> <span class="n">browser</span> <span class="n">core</span><span class="p">.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">![</span><span class="n">image</span><span class="p">](</span><span class="n">https</span><span class="p">:</span><span style="color: #74777d">//www.falkon.org/images/screenshot.png)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just mentioning that it is a KDE web browser and maybe also that it uses QtWebEngine is enough.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111228">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:5</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span class="n"><span class="bright">QtWebEngine</span></span><span class="bright"> </span><span class="n"><span class="bright">web</span></span><span class="bright"> </span><span class="n"><span class="bright">browser</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span class="p"><span class="bright">##</span></span><span class="bright"> </span><span class="n"><span class="bright">Introduction</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">__Falkon__</span> <span style="color: #aa4000">is</span> <span class="n">a</span> <span class="n">KDE</span> <span class="n">web</span> <span class="n">browser</span> <span class="n">using</span> <span class="n">QtWebEngine</span> <span class="n">rendering</span> <span class="n">engine</span><span class="p">,</span> <span class="n">previously</span> <span class="n">known</span> <span style="color: #aa4000">as</span> <span class="n">QupZilla</span><span class="p">.</span> <span class="n">It</span> <span class="n">aims</span> <span class="n">to</span> <span class="n">be</span> <span class="n">a</span> <span class="n">lightweight</span> <span class="n">web</span> <span class="n">browser</span> <span class="n">available</span> <span class="n">through</span> <span class="n">all</span> <span class="n">major</span> <span class="n">platforms</span><span class="p">.</span> <span class="n">This</span> <span class="n">project</span> <span class="n">has</span> <span class="n">been</span> <span class="n">originally</span> <span class="n">started</span> <span class="n">only</span> <span style="color: #aa4000">for</span> <span class="n">educational</span> <span class="n">purposes</span><span class="p">.</span> <span class="n">But</span> <span class="n">from</span> <span class="n">its</span> <span class="n">start</span><span class="p">,</span> <span class="n">Falkon</span> <span class="n">has</span> <span class="n">grown</span> <span class="n">into</span> <span class="n">a</span> <span class="n">feature</span><span class="p">-</span><span class="n">rich</span> <span class="n">browser</span><span class="p">.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove this whole Introduction part.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111229">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">$</span> <span class="n">cmake</span> <span class="p">..</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">$</span> <span class="n">make</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">$</span> <span class="n">sudo</span> <span class="n">make</span> <span class="n">install</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">make && make install</tt> no sudo</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111230">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:25</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="err">```</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span class="n"><span class="bright">mkdir</span></span><span class="bright"> </span><span class="n"><span class="bright">build</span></span><span class="bright"> </span><span class="p"><span class="bright">&&</span></span><span class="bright"> </span><span class="n"><span class="bright">cd</span></span><span class="bright"> </span><span class="n"><span class="bright">build</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span class="n"><span class="bright">cmake</span></span><span class="bright"> </span><span class="p"><span class="bright">..</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span class="n"><span class="bright">To</span></span><span class="bright"> </span><span class="n"><span class="bright">run</span></span><span class="bright"> </span><span class="n"><span class="bright">Falkon</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span class="err"><span class="bright">```</span></span><span class="bright"></span><span class="n"><span class="bright">sh</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is wrong. You should always run the installed binary.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111231">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="err">```</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">##</span> <span class="n">Dependencies</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">-</span> <span class="n">gcc</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ul class="remarkup-list">
<li class="remarkup-list-item">gcc: it also works with other compilers, remove this</li>
<li class="remarkup-list-item">cmake. should be spelled "CMake"</li>
<li class="remarkup-list-item">QT 5: should be spelled "Qt 5"</li>
</ul>

<p style="padding: 0; margin: 8px;">either use package names everywhere or nowhere</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">libxcb-util-dev: it's only dependency on Linux and only when not building with NO_X11</li>
<li class="remarkup-list-item">extra-cmake-modules: should be moved under cmake</li>
<li class="remarkup-list-item">libssl-dev: should be just OpenSSL</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19804#inline-111232">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="err">`</span><span class="n">Note</span><span class="p">:</span><span class="err">`</span><span class="n">If</span> <span class="n">you</span> <span class="n">have</span> <span class="n">installed</span> <span class="n">QT</span> <span class="n">externally</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">then</span> <span class="n">you</span> <span class="n">need</span> <span class="n">to</span> <span class="n">specify</span> <span class="n">its</span> <span class="n">path</span> <span class="n">insted</span> <span class="n">of</span> <span class="err">`</span><span class="n">cmake</span> <span class="p">..</span><span class="err">`</span> <span class="n">put</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This applies to all dependencies, I don't think mentioning it only for Qt makes sense</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19804">https://phabricator.kde.org/D19804</a></div></div><br /><div><strong>To: </strong>saishm, Falkon, drosca<br /><strong>Cc: </strong>SGOrava, ognarb, falkon, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo, ach<br /></div>