<table><tr><td style="">drosca requested changes to this revision.<br />drosca added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18090">View Revision</a></tr></table><br /><div><div><p>This doesn't fix anything.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp: In member function ‘virtual const QMetaObject* ExternalJsObjectWrapper::metaObject() const’:
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp:251:35: error: ‘retriveMetaObject’ is not a member of ‘PySide::SignalManager’
     return PySide::SignalManager::retriveMetaObject(reinterpret_cast<PyObject*>(pySelf));
                                   ^~~~~~~~~~~~~~~~~
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp: In function ‘PyObject* Sbk_ExternalJsObjectFunc_registerExtraObject(PyObject*, PyObject*)’:
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp:390:73: warning: unused parameter ‘self’ [-Wunused-parameter]
 static PyObject* Sbk_ExternalJsObjectFunc_registerExtraObject(PyObject* self, PyObject* args)
                                                               ~~~~~~~~~~^~~~</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18090">https://phabricator.kde.org/D18090</a></div></div><br /><div><strong>To: </strong>krishremya, Falkon, drosca<br /><strong>Cc: </strong>drosca, falkon, Falkon, hase, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, ach<br /></div>