<table><tr><td style="">drosca requested changes to this revision.<br />drosca added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14774">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84405">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.h.cmake:13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: #888888;">(Empty.)</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It should be <tt style="background: #ebebeb; font-size: 13px;">#cmakedefine01 HAVE_LIBINTL</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84404">View Inline</a><span style="color: #4b4d51; font-weight: bold;">history.cpp:330</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">query</span><span class="p">.</span><span class="n">next</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">HistoryEntry</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">entry</span><span style="color: #aa2211">-></span><span class="n">count</span> <span style="color: #aa2211">=</span> <span class="n">query</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">toInt</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same issue here, nothing will delete it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-81646">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drosca</span> wrote in <span style="color: #4b4d51; font-weight: bold;">qmlextensionscheme.cpp:31</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">So this was discussed in the previous review and the outcome was that it will not work like that, and it must pass QJSValue in the signal. Am I correct?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It must be <tt style="background: #ebebeb; font-size: 13px;">requestStarted(const QJSValue &request)</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84407">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmlhistory.cpp:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">list</span><span class="p">.</span><span class="n">reserve</span><span class="p">(</span><span class="n">result</span><span class="p">.</span><span class="n">size</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">HistoryEntry</span> <span style="color: #a0a000">entry</span> <span class="p">:</span> <span class="n">result</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">item</span> <span style="color: #aa2211">=</span> <span class="n">QmlStaticData</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">().</span><span class="n">getHistoryItem</span><span class="p">(</span><span class="n">entry</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const HistoryEntry &entry</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-81659">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drosca</span> wrote in <span style="color: #4b4d51; font-weight: bold;">qmlplugininterface.cpp:121</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">QQuickWidget</tt> instead.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should return <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt>. Again did you test it?</p>
<p style="padding: 0; margin: 8px;">You should use <tt style="background: #ebebeb; font-size: 13px;">QQuickWidget</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">QWidget::createWindowContainer</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84413">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmlstaticdata.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QmlHistoryItem</span> <span style="color: #aa2211">*</span><span class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span><span style="color: #74777d">//m_historyItems.value(entry);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">item</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84411">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmlstaticdata.h:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">bool</span> <span class="n">operator</span> <span style="color: #aa2211">==</span><span class="p">(</span><span class="n">HistoryEntry</span> <span class="n">x</span><span class="p">,</span> <span class="n">HistoryEntry</span> <span class="n">y</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">x</span><span class="p">.</span><span class="n">title</span> <span style="color: #aa2211">==</span> <span class="n">y</span><span class="p">.</span><span class="n">title</span> <span style="color: #aa2211">&&</span> <span class="n">x</span><span class="p">.</span><span class="n">urlString</span> <span style="color: #aa2211">==</span> <span class="n">y</span><span class="p">.</span><span class="n">urlString</span> <span style="color: #aa2211">&&</span> <span class="n">x</span><span class="p">.</span><span class="n">date</span> <span style="color: #aa2211">==</span> <span class="n">y</span><span class="p">.</span><span class="n">date</span> <span style="color: #aa2211">&&</span> <span class="n">x</span><span class="p">.</span><span class="n">count</span> <span style="color: #aa2211">==</span> <span class="n">y</span><span class="p">.</span><span class="n">count</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const-ref</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84412">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmlstaticdata.h:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> <span class="n">uint</span> <span class="n">qHash</span><span class="p">(</span><span class="n">HistoryEntry</span> <span class="n">entry</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">qHash</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span style="color: #766510">"%1 %2 %3 %4"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">title</span><span class="p">,</span> <span class="n">entry</span><span class="p">.</span><span class="n">urlString</span><span class="p">,</span> <span class="n">entry</span><span class="p">.</span><span class="n">date</span><span class="p">.</span><span class="n">toString</span><span class="p">(),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">count</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QSL</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14774#inline-84414">View Inline</a><span style="color: #4b4d51; font-weight: bold;">metadata.desktop:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">Name[cs]=Načtení prostředním tlačítkem myši
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name[en_GB]=MiddleClickLoader
</div><div style="padding: 0 8px; margin: 0 4px; ">Name[es]=Cargador de clic central
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These translations changes are unrelated and should not be here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14774">https://phabricator.kde.org/D14774</a></div></div><br /><div><strong>To: </strong>anmolgautam, drosca<br /><strong>Cc: </strong>falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach<br /></div>