<table><tr><td style="">drosca requested changes to this revision.<br />drosca added inline comments.<br />This revision now requires changes to proceed.<br />Restricted Application added a subscriber: falkon.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11664">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11664#inline-58111">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bookmarkstoolbar.cpp:306</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">BookmarksToolbar</span><span style="color: #aa2211">::</span><span class="n">clearDropIndicator</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should also call <tt style="background: #ebebeb; font-size: 13px;">update()</tt> so you don't need to always call it after <tt style="background: #ebebeb; font-size: 13px;">clearDropIndicator()</tt>-</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11664#inline-58110">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bookmarkstoolbar.cpp:319</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">painter</span><span class="p">.</span><span class="n">setPen</span><span class="p">(</span><span class="n">QPen</span><span class="p">(</span><span class="n">color</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">painter</span><span class="p">.</span><span class="n">drawLine</span><span class="p">(</span><span class="n">m_dropXCoord</span><span class="p">,</span><span style="color: #601200">0</span><span class="p">,</span><span class="n">m_dropXCoord</span><span class="p">,</span><span class="n">height</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There is already code to draw drop indicator in ComboTabBar. It should be extracted from there to eg. QzTools and use it both here and in ComboTabBar.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11664#inline-58109">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bookmarkstoolbarbutton.cpp:316</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">m_dragStartPosition</span><span class="p">).</span><span class="n">manhattanLength</span><span class="p">()</span> <span style="color: #aa2211">></span> <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">startDragDistance</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_dragInProgress</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You don't need to store that drag is in progress as drags are sync.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11664#inline-58108">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bookmarkstoolbarbutton.cpp:327</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">mime</span><span style="color: #aa2211">-></span><span class="n">setImageData</span><span class="p">(</span><span class="n">m_bookmark</span><span style="color: #aa2211">-></span><span class="n">icon</span><span class="p">().</span><span class="n">pixmap</span><span class="p">(</span><span style="color: #601200">16</span><span class="p">).</span><span class="n">toImage</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">mime</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"already-button"</span><span class="p">,</span> <span class="n">pos</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How does dragging between windows work?</p>
<p style="padding: 0; margin: 8px;">It should use custom mimedata with BookmarkItem pointer (see TabModel).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11664#inline-58094">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bookmarkstoolbarbutton.cpp:331</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">drag</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(</span><span class="n">grab</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">drag</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It starts drag on every mouse move event (with pressed mouse button)? Why is it calculating start drag distance then?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11664">https://phabricator.kde.org/D11664</a></div></div><br /><div><strong>To: </strong>anmolgautam, drosca, Falkon<br /><strong>Cc: </strong>falkon, herrold, ixoos, anmolgautam, iodelay, spoorun, navarromorales, cochise, clivej, ach<br /></div>