<html><head></head><body>Hello Matthieu, <br>
Great to hear that you find the file browser useful. I'm currently quite short on time, so please go ahead. It will certainly be nice if these two branches will be integrated for the next release.<br>
<br>
Best regards,<br>
Alex <br><br><div class="gmail_quote">On May 27, 2018 10:48:10 PM GMT+02:00, Matthieu Gallien <gallien.matthieu@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hello Alex,<br><br>I have just had a try to the file_browser branch and it is really looking <br>good. This is really a big contribution to Elisa. Congratulations.<br><br>I would like to get this going into master as fast as possible. I have a few <br>minor issues I would like to fix directly in the branch. Is it OK for you ?<br><br>We should probably start listing the remaining issues for the next release and <br>try to fix as much as we can.<br><br>I have a somehow working branch for navigating from all genres -> all artists <br>with one genre -> all albums from artists -> all tracks from album .<br><br>I would like to get your branch in so that I can integrate all those works <br>together for the next release.<br><br>What do you think ?<br><br>On jeudi 17 mai 2018 21:55:31 CEST you wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hello Alex,<br> <br> On jeudi 17 mai 2018 21:46:52 CEST Alexander Stippich wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hello,<br> <br> I pushed a branch "file_browser" which contains the changes for a simple<br> file browser. It is probably a somewhat naive implementation since my c++<br> skills are still limited, but it seems to work with a couple of issues<br> exposed in Elisa.<br> It only allows browsing the home directory. Only audio files are shown and<br> only viewing is possible. Copy, paste etc. is not implemented. Filtering<br> and sorting is implemented similarly to the other views.<br> <br> Any help and/or feedback is appreciated, of course.<br></blockquote> <br> I am now focused on ensuring that we get genre and file browsers in the next<br> release. I will try to help you as much as I can.<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> It is based on KIO, which provide exactly what is needed. Requiring KIO<br> should not be a problem, since it is available on all platforms (I think<br> even Android is now supported). One could also try to make the file<br> browser<br> optional. QFileSystemModel does not work for this use-case, unfortunately.<br></blockquote> <br> I did not yet checked what is the situation on Android with respect to KIO.<br> <br> This could also be an opportunity to have access to webdav support as it has<br> been requested several times and could allow to offer a very basic<br> integration with Nextcloud.<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Current issues (that I know of):<br> -Loading of the metadata for the metadata view is blocking. I also don't<br> like the interface I've implemented via the proxy model. Maybe we can<br> create an interface for the trackslistener to offload the scanning?<br> -Files without title, artist and album tags do not work/show up yet<br> correctly. Part of this lies in the issue with the mediaplaylist I<br> mentioned in the previous email. The other is due to Elisa expecting these<br> tags to be present. The scanning function in elisautils currently sets the<br> tracks to invalid if those are missing, but just removing the checks is<br> not<br> sufficient. Some help here would be great.<br> -The icons for audio files are vertically not center-aligned. This is a<br> breeze icon issue. I've already reported a bug, but no activity so far.<br> -I'm not able to recreate the plugins.qmltypes, it always complaints about<br> "Component not ready"<br></blockquote> <br> The missing file is my fault and missing in the integration of the qml c++<br> plugin. I will fix it.<br> <br> I may be quite busy the coming week-end but I will do my best to help you on<br> that.<br> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Best regards,<br> Alex<br> <br> <br><hr><br> Elisa mailing list<br> Elisa@kde.org<br> <a href="https://mail.kde.org/mailman/listinfo/elisa">https://mail.kde.org/mailman/listinfo/elisa</a><br></blockquote> <br> Best regards<br> <br> --<br> Matthieu Gallien<br></blockquote><br><br><br><br><hr><br>Elisa mailing list<br>Elisa@kde.org<br><a href="https://mail.kde.org/mailman/listinfo/elisa">https://mail.kde.org/mailman/listinfo/elisa</a><br></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>