<div dir="ltr"><div>Thank you for your responses :)</div><div>I will share my thought on the implementation, but before that could someone please clarify what is the "round red button" is being referred to? Maybe I'm using a different theme, so please clarify, because I don't want to start explaining without completely understanding the doubt.</div><div><br></div><div>Thanks<br></div><div>Kartik<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 17, 2020 at 4:17 PM Maik Qualmann <<a href="mailto:metzpinguin@gmail.com">metzpinguin@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hmm, in my opinion the round red button should ignore the face and no longer <br>
display it in future face detections. The "-" button should make an <br>
unconfirmed face an unknown face again.<br>
<br>
Maik<br>
<br>
Am Sonntag, 17. Mai 2020, 12:07:24 CEST schrieb Thanh Trung Dinh:<br>
> The implementation is really good, well done Kartik!<br>
> Besides, talking about the red button, I think its functionality is not for<br>
> turning unknown faces to ignored faces. Clicking on the "*-*" button turns<br>
> an unconfirmed face to ignored face, but clicking red button will remove<br>
> face tag completely I suppose. Then, when you run face detection again with<br>
> option "skip already scanned images", those faces (rejected by the red<br>
> button) will not appear, but when you run again with option "scan again and<br>
> merge results", those faces will be rescanned and appear again if there are<br>
> faces detected. For me, the functionality of the red button is quite<br>
> confused. Correct me if my observation above is wrong, but I think that the<br>
> red button should be hidden on the overlay. What do you think?<br>
> <br>
> <br>
> <br>
> On Sun, May 17, 2020 at 11:07 AM Maik Qualmann <<a href="mailto:metzpinguin@gmail.com" target="_blank">metzpinguin@gmail.com</a>><br>
> <br>
> wrote:<br>
> > I like the implementation very much, good job. But if I ignore a face (the<br>
> > red<br>
> > round overlay button), it is found again. I did the manual detection on an<br>
> > image. When I look to the "ImageTagProperty" table the region was deleted<br>
> > and<br>
> > didn't get the "Ignored" Tag ID. So it will be found again.<br>
> > <br>
> > Maik<br>
> > <br>
> > Am Sonntag, 17. Mai 2020, 08:59:07 CEST schrieb Kartik Ramesh:<br>
> > > Hello all, I've managed to implement the feature for Ignored Faces. I've<br>
> > > pushed to the digikam repo. please let me know if it's appropriate.<br>
> > > <br>
> > > The basic idea is as follows :<br>
> > > 1. Pressing Reject on Unknown Faces, should mark the face as Ignored.<br>
> > <br>
> > This<br>
> > <br>
> > > will create a new tag, and move the face to it.<br>
> > > 2. Running a Face Detection now, will not re-detect the Ignored Face<br>
> > <br>
> > (even<br>
> > <br>
> > > if Scan again and Merge is selected). Facial Recognition will not try to<br>
> > > recognize the ignored faces, and will never suggest names for an ignored<br>
> > > face.<br>
> > > 3. I have re-designed overlay for Ignored Faces in particular. Pressing<br>
> > <br>
> > the<br>
> > <br>
> > > confirm button, on an Ignored Face will un-mark the face as Ignored, and<br>
> > > move it to Unknown.<br>
> > > <br>
> > > Changes made to directories:<br>
> > > core/app<br>
> > > core/utilities<br>
> > > core/libs<br>
> > > <br>
> > > To do:<br>
> > > 1. The people sidebar should display Ignored Faces at the bottom, as it<br>
> > > isn't of priority to the user.<br>
> > > 2. Add Ignored Property to the metadata of the image, as discussed<br>
> > <br>
> > earlier.<br>
> > <br>
> > > Regards<br>
> > > Kartik<br>
<br>
<br>
<br>
<br>
</blockquote></div>