<div dir="ltr">Look the krazy report here :<div><br></div><div><a href="https://www.digikam.org/reports/krazy/gsoc18-exporttools-o2/">https://www.digikam.org/reports/krazy/gsoc18-exporttools-o2/</a><br></div><div><br></div><div>This part is for you :</div><div><br></div><div><span class="gmail-toolmsg" style="border-style:dotted;border-width:1px 0px;font-family:sans-serif;color:rgb(86,83,48);background:rgb(255,246,143);display:block;padding-left:8px;padding-top:4px;padding-bottom:4px;font-size:medium;text-align:left;text-decoration-style:initial;text-decoration-color:initial">Check single-char QString operations for efficiency [doublequote_chars]...<b>OOPS! 14 issues found!</b></span><ul style="margin:0px;padding:0px;list-style-type:none;color:rgb(0,0,0);font-family:"Times New Roman";font-size:medium;text-align:left;text-decoration-style:initial;text-decoration-color:initial"><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += "{";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += "{";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += "}";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += "}";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += ",";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: => data += "]";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/google/gphoto/gptalker.cpp</a>: line#<span> </span><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0678" style="text-decoration:none;color:inherit;font-weight:bold">678</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0695" style="text-decoration:none;color:inherit;font-weight:bold">695</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0701" style="text-decoration:none;color:inherit;font-weight:bold">701</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0702" style="text-decoration:none;color:inherit;font-weight:bold">702</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0705" style="text-decoration:none;color:inherit;font-weight:bold">705</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0710" style="text-decoration:none;color:inherit;font-weight:bold">710</a><span> </span>(6)</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/smugmug/smugtalker.cpp</a>: => QStringList words = n.split(" ");</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold">/core/utilities/assistants/webservices/smugmug/smugtalker.cpp</a>: split issues line#<span> </span><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp#0324" style="text-decoration:none;color:inherit;font-weight:bold">324</a><span> </span>(1)</li></ul><p class="explanation" style="margin-top:1ex;margin-left:32px;padding:18px;font-size:small;border-width:1px;border-color:rgb(0,0,48);border-style:dashed;background-color:rgb(250,250,210);text-align:justify;color:rgb(0,0,0);font-family:"Times New Roman";text-decoration-style:initial;text-decoration-color:initial">Adding single characters to a QString is faster if the characters are QChars and not QStrings. For example: QString path = oldpath + "/" + base is better written as QString path = oldpath + '/' + base. Same holds for arguments to QString::startsWith(), QString::endsWith(), QString::remove(), QString::split(). Use QString::remove() instead of QString::replace(foo,"")</p>Gilles</div><div class="gmail_extra"><br></div></div>