<div dir="ltr">As i can see too, the noCopyConstructor are mostly false positive, excepted for some cases where this king of constructor must be explicit and not delegate to the compiler. There are a lots of reports, and to review all will take a while.<div><br></div><div>Gilles</div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-05-17 22:00 GMT+02:00 Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The noConstructor warnings are all false positive as i can see, or i don't understand the warning description.<span class="HOEnZb"><font color="#888888"><div><br></div><div>Gilles</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2018-05-17 21:59 GMT+02:00 Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Look also the noExplicitConstructor entries :<div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/</a></div><div><br></div><div>Currently, with Krazy static analyzer, i disable the warnings, and all re-appear with cppcheck.</div><div><br></div><div>This is a tedious problem. Try to force a missing explicit constructor, as :</div><div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/93.html#line-73" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/93.html#<wbr>line-73</a><br></div><div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/93.html#line-89" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/93.html#<wbr>line-89</a><br></div><div><br></div><div>From Face Management code, and you will see a lots of errors.</div><div><br></div><div>Typically, the right constructor choice is delegate to the compiler, and the state at run time can be undefined. This is especially the case for contructor with one argument or more than one but with 2nd, 3rd, etc... using default values.</div><div><br></div><div>I already fixed some simple case, but it's the hell to apply fix everywhere, and i'm sure that side effect are introduced without explicit specifier.</div><div><br></div><div>More details here :</div><div><br></div><div><a href="https://stackoverflow.com/questions/121162/what-does-the-explicit-keyword-mean" target="_blank">https://stackoverflow.com/ques<wbr>tions/121162/what-does-the-<wbr>explicit-keyword-mean</a><span class="m_-1474560213103115661HOEnZb"><font color="#888888"><br></font></span></div><span class="m_-1474560213103115661HOEnZb"><font color="#888888"><div><br></div><div>Gilles</div></font></span></div><div class="m_-1474560213103115661HOEnZb"><div class="m_-1474560213103115661h5"><div class="gmail_extra"><br><div class="gmail_quote">2018-05-17 19:19 GMT+02:00 Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div>I very well advanced with cppcheck static analyzer reports review, and i fixed around 300 entries since 2 weeks...</div><div><br></div><div>But, as usual, the mostly difficult task is always at end, and the last reports sound like... special...</div><div><br></div><div>Look this one :</div><div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/27.html#line-195" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/27.html#line<wbr>-195</a><br></div><div><br></div><div>If we have really an error here, digiKam will crash very quickly when an image is open with DImg container. A false positive ?</div><div><br></div><div>And what's about these 4 entries about equality operator :</div><div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/17.html#line-90" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/17.html#line<wbr>-90</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/48.html#line-179" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/48.html#line<wbr>-179</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/83.html#line-55" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/83.html#line<wbr>-55</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/94.html#line-531" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/94.html#line<wbr>-531</a><br></div><div><br></div><div>And definitively, i lost with these one :</div><div><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/51.html#line-635" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/51.html#line<wbr>-635</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/67.html#line-56" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/67.html#line<wbr>-56</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/70.html#line-185" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/70.html#line<wbr>-185</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/70.html#line-188" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/70.html#line<wbr>-188</a><br></div><div><a href="https://www.digikam.org/reports/cppcheck/master/70.html#line-191" target="_blank">https://www.digikam.org/report<wbr>s/cppcheck/master/70.html#line<wbr>-191</a><br></div><div><br></div><div>Where these virtual calls appears in source code ?</div><div><br></div><div>Any tips, viewpoints, and guidance ?</div><div><br></div><div>Best</div><span class="m_-1474560213103115661m_6311218275892774983HOEnZb"><font color="#888888"><div><br></div><div>Gilles Caulier</div></font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>