<div dir="ltr">There are plenty of code to add in 6 branch : new face recognition algorithm based on deep-learning for ex. The code is mostly ready as i see. At least it compile and run.<div><br></div><div>The code to separate similarity database from core database, started by Swaty while this summer need to be finalized and backported to 6.x branch. For this one, i don't know if Mario has completed the project, as he said previously few weeks ago in September.</div><div><br></div><div>Gilles</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-10-31 16:53 GMT+01:00 Simon Frei <span dir="ltr"><<a href="mailto:freisim93@gmail.com" target="_blank">freisim93@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
I browsed around in tags, dates and gps modules and everything
seemed to work - after all I didn't change anything relevant to it.
I only removed unused code and changed weirdly named mime-types for
drag-drop. Drag and drop still works too.<br>
<br>
Sure, we can start a branch for 6. What would be the idea for that?
I.e. what will be included in new 5.x release, what goes into 6?
Creating a branch for 6 just for my changes would be far overkill,
this is really minor.<div><div class="h5"><br>
<br>
<div class="m_-5212576992678677682moz-cite-prefix">On 31/10/17 10:36, Gilles Caulier
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Simon,</div>
<div><br>
</div>
I check the patch, and i think it must work. I don't yet tested
the changes and as KIO is not used anymore, this will work i
think.
<div><br>
</div>
<div>You need to look is no side effect are introduced by these
changes, especially with all search tools (GPS, date, tags,
advanced, faces).</div>
<div><br>
</div>
<div>I recommend to not include this patch in 5.x but later in
6.0, just to be sure.</div>
<div><br>
</div>
<div>This want mean that certainly the 6.0.0 branch must be
created in git, now.</div>
<div><br>
</div>
<div>Important : there is another part not yet removed in
database, and fully relevant of KIO. </div>
<div>The dbus wrapping with database engine exists. The code is
typically dead and wrapped with a special pre-compiler flag :
"HAVE_DBUS"</div>
<div>grep this string in core/libs/database area. All this code
is not compiled under Windows and MacOS, as DBUS is not
available as stable components. digiKam work as expected.</div>
<div><br>
</div>
<div>In fact under Linux, even if code is compiled, the code is
never used, because KIO slave have been removed. The goal of
this code, written by Marcel few years ago is to be able to
query the DB through KIO slave and DBus from multiple local
instance of Digikam. One instance run in RW mode with the DB,
others ones in R mode only. It's a special use case of course.</div>
<div><br>
</div>
<div>Marcel can certainly explain better the concept here if
necessary.</div>
<div><br>
</div>
<div>Gilles</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-10-30 18:05 GMT+01:00 Simon Frei <span dir="ltr"><<a href="mailto:freisim93@gmail.com" target="_blank">freisim93@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I came
across unused code like kioUrls on drag items, outdated<br>
mime-names for drag-drop and unused function databaseUrl()
on<br>
imageInfos. The patch that fixes these issues is attached,
it compiled<br>
fine. Unless there is any opposition I will push tomorrow.<br>
<br>
Cheers,<br>
Simon<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>