<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hey Simon,<br>
<br>
I finally had the time after the conference day to replace the
minimum and maximum similarity selection boxes in fuzzy<br>
search, duplicates search and maintenance by a new, generic
DIntRangeBox (in libs/widgets/common) which makes the look, <br>
feel and behaviour consistent in all places.<br>
The commit can be found here:
<a class="moz-txt-link-freetext" href="https://commits.kde.org/digikam/903c53415f3fa63d53f02eb828e3169cb4cc9009">https://commits.kde.org/digikam/903c53415f3fa63d53f02eb828e3169cb4cc9009</a><br>
I already tested the behaviour yesterday. There may be need for
polishing, potentially. The fuzzy image search panel does not look
really nice yet.<br>
The DIntRangeBox can be used for all int value ranges. I can think
of it being used as input to search for images in a range of 0 to x
MB/KB/GB, for example.<br>
I do not know which potential applications there are additionally.
But at least, it enforces the order of min and max value. Also it
emits signals on min and max<br>
value change.<br>
<br>
Also, I lift this now quite old discussion to our now more clean dev
room.<br>
<br>
Regards,<br>
Mario<br>
<br>
<blockquote type="cite"
cite="mid:3d8cd2c2-f123-f7a9-db4c-6f80caf6d3ef@gmail.com">
<div class="moz-cite-prefix">On 14/04/17 15:15, Mario Frank wrote:<br>
</div>
<blockquote
cite="mid:ea1ba590-222f-7a55-0efe-e4be9001e75c@uni-potsdam.de"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<p>Hi Simon,</p>
<p>The similarity range is not necessarily the same for fuzzy
and duplicates search.</p>
<p>Consider that yo dou a duplicates search and see an image
where you are sure that there is a near-duplicate which is not
listed,</p>
<p>as it's similarity is lower, for example. Then you can do a
fuzzy search for this specific image. And in this case you
want to be able</p>
<p>to use different similarity thresholds. But you want to still
have the previous thresholds in duplicates search.</p>
<p>Yeah, I saw the GUI changes and they look good as I
mentioned. This is the stuff that I sometimes do not see. So,
feedback and hints</p>
<p>for improvement are appreciated.</p>
<p>Cheers,</p>
<p>Mario<br>
</p>
<br>
<div class="moz-cite-prefix">Am 14.04.2017 um 12:38 schrieb
Simon Frei:<br>
</div>
<blockquote type="cite"
cite="mid:147ce9e9-641c-1bf2-b15d-d5b104a797ee@gmail.com">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Mario,<br>
<br>
I am not sure I can follow with everything you wrote, but that
is exactly why it sounds good that you annex this :)<br>
I assumed the limits should not independent in the tree
places, where it is used, as I didn't think you necessarily
want the same range for e.g. duplicate and image search.<br>
Also did you notice the small GUI changes (some column stretch
and padding adjustments) as well?<br>
<br>
Cheers,<br>
Simon<br>
<br>
<div class="moz-cite-prefix">On 14/04/17 12:30, Mario Frank
wrote:<br>
</div>
<blockquote
cite="mid:da39ec12-daea-157c-36e3-816e97123ae9@uni-potsdam.de"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Hey Simon,<br>
<br>
I'm sitting in a train and had the time to look at the
patch.<br>
The idea to extract the similarity interval as class is
good.<br>
And the polishing part seems also good at first glance.<br>
But I think the way you extract the similarity interval does
not go in the right direction.<br>
We should enforce consistent look&feel and also
behaviour everywhere we use such constructs.<br>
And the max and min widget should not be directly accessed.<br>
<br>
We use similarity interval in <br>
- duplicates search in the fuzzy search sidebar<br>
- duplicates search in the maintenance dialogue<br>
- fuzzy image/drop search in fuzzy sidebar<br>
<br>
In every spot, it should look and behave the same way.<br>
<br>
If this is okay for all of you, I would annex the
(fuzzy/duplicates) searches part more or less as I think
that I now have a quite good overview<br>
of the codebase in that part.<br>
<br>
If this is okay, I would rewrite your idea and implement it
more generic, i.e. create a widget for ranges/intervals <br>
under libs/widgets/common.<br>
<br>
This way, the behaviour of altering the maximum and minimum
would be encapsulated and easier to confirm as correct.<br>
How does that sound?<br>
<br>
Cheers,<br>
Mario<br>
<br>
<div class="moz-cite-prefix">Am 13.04.2017 um 23:26 schrieb
Simon Frei:<br>
</div>
<blockquote type="cite"
cite="mid:816b5dea-271b-1726-68c9-629414d41b06@gmail.com">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Mario,<br>
<br>
The patch in <a class="moz-txt-link-freetext"
href="https://bugs.kde.org/show_bug.cgi?id=353331"
moz-do-not-send="true">https://bugs.kde.org/show_bug.cgi?id=353331</a>
is in master, right? Can this bug be closed?<br>
Also I removed some more unnecessary borders around widget
and did other minor GUI polishing regarding fuzzy
searches. Also I did a little refactor around the
similarity limit controls.<br>
I don't really have the overview over which are the
relevant bugs, so I attached it here.<br>
<br>
Cheers,<br>
Simon<br>
<br>
<div class="moz-cite-prefix">On 04/04/17 17:10, Mario
Frank wrote:<br>
</div>
<blockquote
cite="mid:adfd5e53-65ef-9cd3-9062-28d7794e9277@uni-potsdam.de"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Simon,<br>
<br>
after polishing some parts, I was finding myself more in
refactoring the AlbumSelectors class.<br>
I found out that the duplicates search itself allows
searching both in tags and in albums.<br>
But the AlbumSelectors only returns either PAlbums or
TAlbums (one of the lists is empty) depending on<br>
the selected tab.<br>
<br>
So I refactored the class and it now returns all
selected albums with selectedAlbums and the selected
tags<br>
with selectedTags no matter which tab is chosen in
duplicates search.<br>
In Fuzzy image and sketch search, selectedTags returns
an empty list.<br>
<br>
So I could now squeeze the (I think) last way on
restricting the duplicates search results, i.e.<br>
The user can select both tags and albums and apply one
of 5 operations to the selected objects:<br>
- "One of" aka union - Search in the set of images that
are either in the selected tags or albums<br>
- "Both" aka intersection - Search in the set of images
that are both in the selected tags and albums<br>
- "Albums but not tags" aka difference - Search in the
set of images that are in the selected albums but not in
the selected tags<br>
- "Tags but not albums" aka difference - Search in the
set of images that are in the selected tags but not in
the selected albums<br>
- "Only selected tab" aka obvious - Search in the
selected albums, if albums tab is active and in the
selected tags if tags tab is active<br>
<br>
With the refactoring, I was also able to fix incorrect
indentation ( the AlbumSelectors was shifted right a
bit).<br>
I have already done some tests which worked without
problems.<br>
<br>
I will attach the current patch to bug <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.kde.org/show_bug.cgi?id=353331">https://bugs.kde.org/show_bug.cgi?id=353331</a>
with some screenshots of the new fuzzy sidebar<br>
so you all can take a look. Sadly, my localisation is
now broken and I have mixed English and German texts.<br>
<br>
I do not see more ways to restrict the results in the
fuzzy sidebar. Further improvements of fuzzy/duplicates
search will be subject to<br>
better duplicates recognition algorithm(s).<br>
<br>
Cheers,<br>
Mario<br>
<br>
<div class="moz-cite-prefix">Am 02.04.2017 um 22:47
schrieb Simon Frei:<br>
</div>
<blockquote
cite="mid:659f7093-3dad-99ce-2fb2-698a4ace29a3@gmail.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Mario,<br>
<br>
I originally just wanted to get rid of the borders
around the albumselector widget. Then I ran into
problems when the tags tab is not added. This lead to
quite a lot more changes than intended. This now
ensures that no operations regarding tags happen, when
the albumselector was constructed without tags
selecting and I simplified some things.<br>
In my opinion this change is big enough to warrant his
own branch. Is just much easier and less error prone
(at least for me) than exchanging patches by email.<br>
<br>
Cheers,<br>
Simon<br>
<br>
<div class="moz-cite-prefix">On 01/04/17 13:35, Mario
Frank wrote:<br>
</div>
<blockquote
cite="mid:C2002FEA-3D3A-4120-8D16-13DC5B7BF4AF@uni-potsdam.de"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hey Simon,<br>
<br>
Yes, the restriction should be either to albums or
to tags. The not selected restriction variant is
still disabled. I just wored it now to the selected
tab instead of checkbox.<br>
<br>
I don't allow to restrict on tags for complexity
reasons. We have a one to one relation between
albums and images. So checking if an image belongs
to an album is a constant time check. This does not
hold for tags. If I let them restrict to tags, I
would have to check if one of the image tags is in
the selected tags list. This is a linear complexity
operation. And the more they tag their images, the
slower the check will be. It is even possible that
restricting by tags can make the search slower than
without restriction. That's why I wrote that I do
not see a value. The drawback can be higher than the
gain.<br>
<br>
Cheers,<br>
Mario <br>
<br>
<div class="gmail_quote">Am 1. April 2017 00:58:13
MESZ schrieb Simon Frei <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:freisim93@gmail.com"><freisim93@gmail.com></a>:
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;"> One more thing I
forgot: Previously the other type (either album
or tag) was disabled. It is still meant, that
the user chooses either tags or albums, not a
mixture of both by switching between the tabs,
correct?<br>
<br>
<div class="moz-cite-prefix">On 31/03/17 22:21,
Gilles Caulier wrote:<br>
</div>
<blockquote
cite="mid:CAHFG6sEgA8=UvC8jGL4sBNNNit_5SN7wPyL4ctuF9G-6v+bQTA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-03-31 17:32
GMT+02:00 Mario Frank <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:mafrank@uni-potsdam.de"
target="_blank">mafrank@uni-potsdam.de</a>></span>:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">Hey Guys,<br>
<br>
I was working lately on improving the
fuzzy search sidebar.<br>
<br>
We have some bug reports that are a
bit frustrating, namely<br>
1) <a moz-do-not-send="true"
href="https://bugs.kde.org/show_bug.cgi?id=353331"
rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.<wbr>cgi?id=353331</a><br>
2) <a moz-do-not-send="true"
href="https://bugs.kde.org/show_bug.cgi?id=372972"
rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.<wbr>cgi?id=372972</a><br>
<br>
Both bug reports complain that the
album selection box in the duplicates<br>
view only contains the root albums.<br>
The reason is that in a new
installation, the root albums are not<br>
automatically expanded. This is a
usability problem<br>
which I was able to solve quite
easily. (fixes 372972 and partially
353331)<br>
<br>
Then I found a bug in the fuzzy
search. If the maximum and minimum<br>
similarity are identical (let's say 50
%)<br>
only images with 50,00 % similarity
are found though there should also<br>
be results with 50,xy %.<br>
I could also fix that easily.<br>
<br>
Moreover I rewrote the AlbumSelector
from a combo box based object to a<br>
tab based object which saves us quite
some space (addresses 353331).<br>
</blockquote>
<div><br>
</div>
<div>Interesting. This concept can be
certainly use in other place.</div>
<div><br>
</div>
<div>I'm curions : Which kind of space
do you save by this way ? Can you take
a shot ?</div>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"> Also, I added
the possibility to restrict the fuzzy
image/drop/sketch<br>
search to albums by adding an
AlbumSelector. I only let the user<br>
restrict to albums<br>
but not to tags as the albums are the
object the user sees. I currently<br>
do not see additional value in
restricting to tabs in this case.<br>
The rearch results are also refreshed
when selecting or deselecting an<br>
album and also when toggling the whole
albums button.<br>
<br>
Finally I fixed a bug in the SAlbum
query creation for fuzzy<br>
image/dropped/sketch searches. The
"search" tag was not closed. This had<br>
no bad effects<br>
but is still not nice.<br>
</blockquote>
<div><br>
</div>
<div>Ah, i see this bug under OSX. I
think a report already exists in
bugzilla. </div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"> <br>
What I could not fix (though I tried
in multiple ways) is that in the<br>
AlbumSelector, the selection count
summary is not shown after starting<br>
digiKam.<br>
The correct albums are checked but the
text field is not filled with the<br>
summary. Do you have any clue how to
solve this?<br>
</blockquote>
<div><br>
</div>
<div>I'm not sure to understand well.
Which summary do you talk exactly ?</div>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"> Normally, I
would append the patch to a bug report
but since it<br>
addresses many small problems, I
append it here. Would all of you who<br>
have time review it?<br>
</blockquote>
<div><br>
</div>
<div>Personalty not this week end. I
teach tomorrow all the day, and must
complete a huge project based on Qt5
in my office to draw real time
measurement curves from Tokamak.</div>
<div><br>
</div>
<div>Also Sunday it's GSoC 2017
proposals review period starting. This
will take time too...</div>
<div><br>
</div>
<div>best</div>
<div><br>
</div>
<div>Gilles</div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"> <br>
Cheers,<br>
Mario<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</blockquote>
</div>
<br>
-- <br>
Diese Nachricht wurde von meinem
Android-Mobiltelefon mit K-9 Mail gesendet. </blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>