<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129088/">https://git.reviewboard.kde.org/r/129088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 3rd, 2016, 2:26 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On October 3rd, 2016, 2:33 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Excelent. Thanks Antonio.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code is fine for me to commit, if condition below are also fixed :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1/ Gelocation Editor data file need to be migrated too, as it's reported in another bugzilla entry :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://bugs.kde.org/show_bug.cgi?id=368968</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also this entry have been re-opened. Your patch must fix it typically :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://bugs.kde.org/show_bug.cgi?id=357944</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gilles Caulier</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, I wasn't aware of those bugs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1/ I've already added code for that and when I test it I'll push it if that's ok for you. Note I'll test with a simple geobookmarks.xml file since I don't have a real one to test, but since the migration should just copy it, the contents don't really matter.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2/ I think my patch already takes care of that. It url-decodes the albumroot identifiers which start with "volumeid:?path=%2F". In my database I only had two kind of albumroots:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One with identifier="volumeid:?path=%2Fhome%2Fantonio%2FPictures" and specificPath="/" which didn't work in digikam5 (until I url-decoded it)
The rest with identifier=volumeid:?uuid=128ff..." and specificPath="/somepath" which worked fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is there any other kind of entry in the albumroots table that should be url-decoded?</p></pre>
<br />
<p>- Antonio</p>
<br />
<p>On October 3rd, 2016, 4:02 p.m. UTC, Antonio Larrosa Jimenez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Antonio Larrosa Jimenez.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2016, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit adds a new page to the FirstRun wizard that allows the user
to choose if he/she wants to do a migration of the digikam4 settings
(only if settings from digikam4 are detected). If the user selects to
create new settings, then the usual wizard continues, and if the user
selects to migrate then
~/.kde4/share/config/digikamrc
~/.kde4/share/config/digikam_tagsmanagerrc
~/.kde4/share/config/kipipluginsrc
~/.kde4/share/config/kipirc
~/.kde4/share/config/showfotorc
are copied to ~/.config/ .
Then all files inside ~/.kde4/share/apps/digikam/
are copied to ~/.local/share/apps/digikam .
And finally, the albumroots are updated in the database since
digiKam 5 doesn't interpret correctly values like
volumeid:?path=%2Fhome%2Fantonio%2FPictures and they need to be
url-decoded.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested by migrating my own digikam instance (which has 5 albumroots, 98701 images and 1707 tags) with a patched openSUSE Tumbleweed digikam 5.2.0 package.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utilities/assistants/firstrun/CMakeLists.txt <span style="color: grey">(7e104fe3ff3c3102b368cd2671bea6e4a3c963b8)</span></li>
<li>utilities/assistants/firstrun/firstrundlg.cpp <span style="color: grey">(cf9bbd2c8ab8bceaab4c0237458a88b3f3dc86b2)</span></li>
<li>utilities/assistants/firstrun/migratefromdigikam4page.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/assistants/firstrun/migratefromdigikam4page.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/assistants/firstrun/welcomepage.cpp <span style="color: grey">(5e630eb46d191f1480922cb732bb48135f60beba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129088/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/005e060a-8636-4b87-9a0f-2a162f22f2ca__migratepage.png">Screenshot of the new migrate page in the FirstRun wizard</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>