<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125551/">https://git.reviewboard.kde.org/r/125551/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On oktobris 14th, 2015, 1:58 p.m. EEST, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the current implementation fix the problem. please try again</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cool, thanks :)</p></pre>
<br />
<p>- Dāvis</p>
<br />
<p>On oktobris 14th, 2015, 9:52 p.m. EEST, Dāvis Mosāns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2015, 9:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #BC7A00">../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':</span>
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This RR fixes it by linking to those required libraries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/3rdparty/dngwriter/CMakeLists.txt <span style="color: grey">(cc82d0a0c1713d7eab5b53d81c263056d5c88fd7)</span></li>
<li>libs/3rdparty/dngwriter/tests/CMakeLists.txt <span style="color: grey">(7fd6136ee652bc3822fc0228059bc84d5302af19)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125551/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>