<div dir="ltr"><div><div><div><div><div><div>Hello,<br><br></div> I went through the source code to figure out more about the working, and here's what I found out.<br></div><br>-- slotCrop() handles the cropping after the shortcut is triggered<br><a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/canvas.cpp#L358" target="_blank">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/canvas.cpp#L358</a><br><br></div>-- The cropping itself is handled by the crop function is dimg.cpp<br><a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/dimg.cpp#L2207" target="_blank">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/dimg.cpp#L2207</a><br><br></div>-- I think the viewer update takes place imagepreviewitem.cpp, but I might be wrong<br><a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/imagepreviewitem.cpp#L57">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/imagepreviewitem.cpp#L57</a><br><br></div>I'm not sure how to go about from here. The preview only messes up when the image is cropped as a vertical band, which I guess means that cropping is not an issue. I began looking into the zoom functions in graphicsdimgview.cpp, and hope to find something there.<br><br></div><div>I'd like to have your say on it though.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 24, 2014 at 1:20 PM, Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Koushik,<br>
<br>
I will post all technical details to bug #335661 after noon (i take<br>
train to go to Paris today)<br>
<br>
Best<br>
<span class="HOEnZb"><font color="#888888"><br>
Gilles Caulier<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
2014-10-23 15:48 GMT+02:00 Koushik S <<a href="mailto:skoushik333@gmail.com">skoushik333@gmail.com</a>>:<br>
> Hi,<br>
><br>
> That's great! And yes, I do plan on working on another bugfix, specifically,<br>
> Bug 335661 (<a href="https://bugs.kde.org/show_bug.cgi?id=335661" target="_blank">https://bugs.kde.org/show_bug.cgi?id=335661</a>). I'm still sifting<br>
> through the source code to understand how it works.<br>
><br>
> On Thu, Oct 23, 2014 at 6:37 PM, Gilles Caulier <<a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Koushik,<br>
>><br>
>> Patch applied to git/master and bug #306767 closed.<br>
>><br>
>> Do you plan to work on another bugzilla entry ?<br>
>><br>
>> Best<br>
>><br>
>> Gilles Caulier<br>
>><br>
>> 2014-10-22 16:16 GMT+02:00 Gilles Caulier <<a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a>>:<br>
>> > Hi,<br>
>> ><br>
>> > Thanks for your help.<br>
>> ><br>
>> > Please use exclusively git/master code to hack and make patches.<br>
>> > Patches must be posted to relevant bugzilla entries.<br>
>> ><br>
>> > Rename action is managed on top level here :<br>
>> ><br>
>> ><br>
>> > <a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021" target="_blank">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/main/digikamapp.cpp#L1021</a><br>
>> ><br>
>> > This call this method in view :<br>
>> ><br>
>> ><br>
>> > <a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822" target="_blank">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/digikamview.cpp#L1822</a><br>
>> ><br>
>> > redirected to icon-view here :<br>
>> ><br>
>> ><br>
>> > <a href="https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651" target="_blank">https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/items/digikamimageview.cpp#L651</a><br>
>> ><br>
>> > Which launch rename dialog. The current selection is passed<br>
>> > byDigikamView::selectedUrls(). Rename dialog perform files renaming in<br>
>> > background and digiKam ScanController will detect files changes from<br>
>> > file system. icon-view contents will change accordingly with<br>
>> > ScanController results.<br>
>> ><br>
>> > So, the IconView selection to restore is not simple to do. You must<br>
>> > take a care about original file names which will be changed by rename<br>
>> > tool, wait ScanController end and restore selection.<br>
>> ><br>
>> > Best<br>
>> ><br>
>> > Gilles Caulier<br>
>> ><br>
>> > 2014-10-21 19:24 GMT+02:00 Koushik S <<a href="mailto:skoushik333@gmail.com">skoushik333@gmail.com</a>>:<br>
>> >> Hello,<br>
>> >><br>
>> >> I'm interested in contributing to the project and needed some<br>
>> >> guidance<br>
>> >> on that. I have compiled and installed digikam from source, and went<br>
>> >> through<br>
>> >> some of the bugs posted at the bugtracking system.<br>
>> >><br>
>> >> I found Bug 306767 (<a href="https://bugs.kde.org/show_bug.cgi?id=306767" target="_blank">https://bugs.kde.org/show_bug.cgi?id=306767</a>) to<br>
>> >> be a<br>
>> >> simple bugfix (I think) with some help. I started to understand a bit<br>
>> >> of the<br>
>> >> codebase, and I found that the selection is done by the drawFocusRect<br>
>> >> in the<br>
>> >> itemviewimagedelegate.cpp file, but I'm not sure how to move on from<br>
>> >> there.<br>
>> >> Any guidance would be helpful.<br>
>> >><br>
>> >> --<br>
>> >> regards,<br>
>> >> Koushik. S<br>
>> >><br>
>> >> _______________________________________________<br>
>> >> Digikam-devel mailing list<br>
>> >> <a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br>
>> >> <a href="https://mail.kde.org/mailman/listinfo/digikam-devel" target="_blank">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>
>> >><br>
>> _______________________________________________<br>
>> Digikam-devel mailing list<br>
>> <a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/digikam-devel" target="_blank">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>
><br>
><br>
><br>
><br>
> --<br>
> regards,<br>
> Koushik. S<br>
><br>
> _______________________________________________<br>
> Digikam-devel mailing list<br>
> <a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/digikam-devel" target="_blank">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>
><br>
_______________________________________________<br>
Digikam-devel mailing list<br>
<a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/digikam-devel" target="_blank">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr"><div>regards,</div>Koushik. S</div>
</div>