<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119201/">https://git.reviewboard.kde.org/r/119201/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sound like it miss something to link digiKam against OpenCV. I got an error under OSX at linking time :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In file included from /Users/gilles/Devel/GIT/4.x/core/libs/database/imgqsort/imgqsort.cpp:25:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /Users/gilles/Devel/GIT/4.x/core/digikam/utils/libopencv.h:38:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /opt/local/include/opencv2/opencv.hpp:47:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /opt/local/include/opencv2/core/core.hpp:4856:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/opt/local/include/opencv2/core/mat.hpp:538:13: warning: cast from 'uchar <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">' (aka 'unsigned char </em>') to 'short <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">' increases required alignment from 1 to 2 [-Wcast-align]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
return ((_Tp</em>)(data + step.p[0]<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">i0))[i1];<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^~~~~~~~~~~~~~~~~~~~~~~~~~~<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/Users/gilles/Devel/GIT/4.x/core/libs/database/imgqsort/imgqsort.cpp:366:31: note: in instantiation of function template specialization 'cv::Mat::at<short>' requested here<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
short value = out.at<short>(i,j);<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
6 warnings generated.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Linking CXX executable digikam.app/Contents/MacOS/digikam<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Undefined symbols for architecture x86_64:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"cv::GaussianBlur(cv::<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">InputArray const&, cv::_OutputArray const&, cv::Size</em><int>, double, double, int)", referenced from:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Digikam::ImgQSort::blurdetector2() const in imgqsort.cpp.o<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"cv::blur(cv::<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">InputArray const&, cv::_OutputArray const&, cv::Size</em><int>, cv::Point_<int>, int)", referenced from:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Digikam::ImgQSort::CannyThreshold(int, void</em>) const in imgqsort.cpp.o<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"cv::Canny(cv::_InputArray const&, cv::_OutputArray const&, double, double, int, bool)", referenced from:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Digikam::ImgQSort::CannyThreshold(int, void<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">) const in imgqsort.cpp.o<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"cv::calcHist(cv::Mat const</em>, int, int const<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, cv::_InputArray const&, cv::_OutputArray const&, int, int const</em>, float const<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, bool, bool)", referenced from:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Digikam::ImgQSort::exposureamount() const in imgqsort.cpp.o<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
"cv::Laplacian(cv::_InputArray const&, cv::_OutputArray const&, int, int, double, double, int)", referenced from:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Digikam::ImgQSort::blurdetector2() const in imgqsort.cpp.o<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
ld: symbol(s) not found for architecture x86_64<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
clang: error: linker command failed with exit code 1 (use -v to see invocation)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make[2]: <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> [core/digikam/digikam.app/Contents/MacOS/digikam] Error 1<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make[1]: </em></strong> [core/digikam/CMakeFiles/digikam.dir/all] Error 2<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make: </strong>* [all] Error 2</p></pre>
<br />
<p>- Gilles Caulier</p>
<br />
<p>On July 22nd, 2014, 8:34 p.m. UTC, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated July 22, 2014, 8:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes Digikam being explicit in what OpenCV components are needed. This results in less number of libraries to be linked to. As a result, Digikam starts a bit faster, eats a bit less memory and makes downstream (packagers) a bit more happy. Also it helps in cases when OpenCV package is split (for example, with non-free components separated) - without explicit mentioning of what components are needed, it's not clear will Digikam link to some components or not.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OpenBSD/i386-CURRENT, KDE 4.11.5+Digikam 3.x and KDE 4.13.2+Digikam 4.x</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/imgqsort/detectnoise/CMakeLists.txt <span style="color: grey">(18ead8a)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d591a2f)</span></li>
<li>tests/imgqsort/detectblur/CMakeLists.txt <span style="color: grey">(29df499)</span></li>
<li>tests/imgqsort/detectcompression/CMakeLists.txt <span style="color: grey">(73ba98d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119201/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>