<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/108821/">https://git.reviewboard.kde.org/r/108821/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam and KDE Graphics.</div>
<div>By Kevin Kofler.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 10:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdcraw
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes the libjpeg detection to check for the availability of jpeg_mem_src rather than for JPEG_LIB_VERSION, allowing to build the JPEG functionality with libjpeg-turbo >= 1.2.90.
RawSpeed/DngDecoderSlices.cpp tries to define its own jpeg_mem_src function if JPEG_LIB_VERSION < 80, so patch it to use the detected USE_JPEG8 instead to avoid the redefinition and the resulting compiler error.
Note: This patch is against 4.10, master is even more broken due to http://commits.kde.org/libkdcraw/016a3f26084b4bf7e0302ede362d937eb2dd4910 ("Fix compilation on Windows"), which unconditionally removes the USE_JPEG define, meaning JPEG support will never be built at all. This is clearly incorrect.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds (and detects jpeg_mem_src) in Rawhide (libkdcraw 4.10.0 release, libjpeg-turbo 20130204 snapshot (svn922, approx. 1.2.90)).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libraw/CMakeLists.txt <span style="color: grey">(581e7b1)</span></li>
<li>libraw/RawSpeed/DngDecoderSlices.cpp <span style="color: grey">(28a137e)</span></li>
<li>libraw/RawSpeed/rawspeed.jpeg-version.patch <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/108821/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>