<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108382/">http://git.reviewboard.kde.org/r/108382/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 26th, 2013, 5:54 p.m. UTC, <b>Marcel Wiesweg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. Sorting is good, the "T" action sounds good.
Putting existing tags to the top and the creation of a new tag to the bottom is a decision based on personal preference. The current behavior favors creating new tags, while the patched behavior favors assigning existing tags by keyboard. Gilles, your opinion?
Some more questions:
- You remove emit currentCompletionTextChanged(current->data...) Why? Unused, causing a bug?
- Why setCurrentRow(0)?</pre>
</blockquote>
<p>On April 26th, 2013, 6:30 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Putting existing tags to the top and the creation of a new tag to the bottom is a decision based on personal preference.
So in this case tags list is not shorted by alpha ?
> The current behavior favors creating new tags,
yes.
>while the patched behavior favors assigning existing tags by keyboard. Gilles, your opinion?
We can considerate this patch introducing a new feature.
Try to use Tags/New tag menu option from AlbumGUI, it only available when a tag is selected from tag tree-view on the left side. It doesn't work when tag is selected from tree-view on the right side.
I we want to be homogeneous, It will be judicious to add a keyboard shortcut to this action, and whole context management must be changed to enable it when focus is given to one of all tags tree-view... No ?
Gilles
</pre>
</blockquote>
<p>On May 30th, 2013, 10:03 p.m. UTC, <b>Markus Leuthold</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marcel, Gilles, sorry for the late response!
>> You remove emit currentCompletionTextChanged(current->data...) Why?
assume your list of most recently used tags only consists of "Paris". Now, if you press "P" in the TagEdit-box "emit currentCompletionTextChanged(current->data...)" will be fired, where the parameter passed to "currentCompletionTextChanged" already contains "Paris". This means the TagEdit-box immediately contains "Paris" after pressing "P". There is no way for the user to add a new tag "Peking" via TagEdit-box. If I start deleting the last letter "Pari", "currentCompletionTextChanged" would be fired again and TagsCompletionBox again contains "Paris".
>> Why setCurrentRow(0)?
After filling up all the items in the setItems method, no row is selected in the TagsCompletionBox. Since the items are already correctly ordered, the most likely candidate will ALWAYS be on the first row, hence parameter 0 for setCurrentRow(). If no item was selected (no setCurrentRow call), the current (first) row would not be returned, instead the so far entered text would be used. Example: your list contains of "Paris", you press "Pa" & enter. Without setCurrentRow(0), a new tag "Pa" would be created.
>> The current behavior favors creating new tags, while the patched behavior favors assigning existing tags by keyboard
This is not entirely true: if you create a new tag, you need to write the entire tag, anyways. As soon as the new tagname does not match anymore with recently assigned tags, you'll have the same choice at the first two rows of the the CompletionBox as it is now. There is one exception: you have "Parisienne" in your list and you want to create the tag "Paris". Then indeed the existing tag is favored.
>> Try to use Tags/New tag menu option from AlbumGUI, it only available when a tag is selected from tag tree-view on the
>> left side. It doesn't work when tag is selected from tree-view on the right side.
Yes, indeed. I never used Tags/New. In my opinion, the entire "Tags" menu entry is probably not necessary, there are already several other options to browse,add,delete tags.
best regards, Markus
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The proposed patch needs some minor modifications, due to rebasing on current master. I successfully use this patch now already for quite a while, may I commit?
best regards
Markus</pre>
<br />
<p>- Markus</p>
<br />
<p>On April 21st, 2013, 1:04 p.m. UTC, Markus Leuthold wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam, Gilles Caulier and Marcel Wiesweg.</div>
<div>By Markus Leuthold.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make tagging more accessible by keyboard
* Pressing "T" will focus the tagedit-box.
* The tag is applied by pressing enter. Pressing enter a second time will
focus the mainwindow and advance to the next image.
* The dropdown of the tagedit-box remembers already entered tags, the
order of the dropdown items are sorted such that already entered tags appear first.
* add tagging-by-keyboard to "Tips of the day"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/tips <span style="color: grey">(eef2262ef39fe77a65113f75be750122bda0f3fb)</span></li>
<li>digikam/main/digikamapp.cpp <span style="color: grey">(d7769e60d4181f95149774744fb93e711761c2ed)</span></li>
<li>digikam/main/digikamapp_p.h <span style="color: grey">(2d9f0c20f65a29db153c868cbfcea2e5574b1bdd)</span></li>
<li>digikam/tags/addtagscompletionbox.cpp <span style="color: grey">(266421c34fe6d939b094d0c0b1dea77065e024ee)</span></li>
<li>digikam/tags/addtagslineedit.h <span style="color: grey">(1eec38c090eaefd592e4cc5c4561fadf04b9de26)</span></li>
<li>digikam/tags/addtagslineedit.cpp <span style="color: grey">(abcf5b1f9d9a0340a9838b267faa2637f989bd96)</span></li>
<li>digikam/views/digikamview.h <span style="color: grey">(669eac958eeaa5aacb52f0a55d879175c4abbe34)</span></li>
<li>digikam/views/digikamview.cpp <span style="color: grey">(89ae95684cef96da14df1807ab821f04d274471a)</span></li>
<li>libs/database/albumdb.cpp <span style="color: grey">(8ca4fd0e0323fb7c8bae65f947d21b9d9ee6b50c)</span></li>
<li>libs/imageproperties/imagedescedittab.h <span style="color: grey">(0dc7e31af05bf95a6caf5ee4edde962bda7c0e7a)</span></li>
<li>libs/imageproperties/imagedescedittab.cpp <span style="color: grey">(b6ce9494852b4a624addefa7c1fb1196ff265e68)</span></li>
<li>libs/imageproperties/imagepropertiessidebar.h <span style="color: grey">(f6703339fc2e1a5762f8db898e7ad69dddab7868)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108382/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>