<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109048/">http://git.reviewboard.kde.org/r/109048/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 17th, 2013, 12:17 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance.
The patch sound fine for me.
>Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?
As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.
If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus.
0x9206 37382 Image Exif.Image.SubjectDistance SRational The distance to the subject, given in meters.
0x100c 4108 Olympus Exif.Olympus.FocusDistance Rational Manual focus distance
Note : exiftool do not give a better explaination abou tthis private tag :
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html
What do you plan to add in your patch ?
>Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.
Do you applied a patch to Exiv2 project ?
Gilles Caulier</pre>
</blockquote>
<p>On March 21st, 2013, 1:52 p.m. UTC, <b>Teemu Rytilahti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.
> If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus.
Yup, at least my camera (Olympus E-PL3) doesn't mark regular (Exif.Photo.)SubjectDistance at all, and I assume that's the case for all those other special cases in there.
> What do you plan to add in your patch ?
The current code already uses Exif.Photo.SubjectDistance as default before trying to check for the vendor specific tags. What makes me wonder though that there's also another standard one (Exif.Photo.SubjectDistance), which isn't handled at all.
Soo, to answer to your question, I think adding this special case should be enough for now?
> Do you applied a patch to Exiv2 project ?
Nope, I haven't been able to get in touch with the maintainer via e-mail and their Redmine doesn't let me login at all. Sent a new message about the matter to Andreas.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eww, okay, forgot to publish that comment yesterday. Anyway, Andreas already responded and I was able to submit the patch: http://dev.exiv2.org/issues/896 . Soo, I shall push the changes to master, right?</pre>
<br />
<p>- Teemu</p>
<br />
<p>On February 19th, 2013, 9:03 p.m. UTC, Teemu Rytilahti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Teemu Rytilahti.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2013, 9:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?
Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/dimg/filters/lens/lensfuniface.cpp <span style="color: grey">(f2bbb620bfa116cb9f72afa7dc2229d02dafd830)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109048/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>