<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108382/">http://git.reviewboard.kde.org/r/108382/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only changes I dont understand without explanation are those to AddTagsCompletionBox::setItems. What is achieved here?
</pre>
<br />
<p>- Marcel</p>
<br />
<p>On January 13th, 2013, 10:16 a.m. UTC, Markus Leuthold wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam, Gilles Caulier and Marcel Wiesweg.</div>
<div>By Markus Leuthold.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2013, 10:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make tagging more accessible by keyboard
* Pressing "T" will focus the tagedit-box.
* The tag is applied by pressing enter. Pressing enter a second time will
focus the mainwindow and advance to the next image.
* The dropdown of the tagedit-box remembers already entered tags, the
order of the dropdown items are sorted such that already entered tags appear first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>digikam/main/digikamapp.cpp <span style="color: grey">(f9a1206faa0ff2c5f174b74728d45e660bfea599)</span></li>
<li>digikam/main/digikamapp_p.h <span style="color: grey">(e4924fc0818715e79919e3ac1de74fbd07e26152)</span></li>
<li>digikam/tags/addtagscompletionbox.cpp <span style="color: grey">(266421c34fe6d939b094d0c0b1dea77065e024ee)</span></li>
<li>digikam/tags/addtagslineedit.h <span style="color: grey">(1eec38c090eaefd592e4cc5c4561fadf04b9de26)</span></li>
<li>digikam/tags/addtagslineedit.cpp <span style="color: grey">(abcf5b1f9d9a0340a9838b267faa2637f989bd96)</span></li>
<li>digikam/views/digikamview.h <span style="color: grey">(418dc019256300315a1623d45ad1a7d6e6c484f7)</span></li>
<li>digikam/views/digikamview.cpp <span style="color: grey">(b8c2f6408d59a638c0c400b81516eedd5d1a621b)</span></li>
<li>libs/database/albumdb.cpp <span style="color: grey">(2d04b1568e46d59a162be0bfdc2105a6d5bb7d2a)</span></li>
<li>libs/imageproperties/imagedescedittab.h <span style="color: grey">(9b229e451c0d14b34b39c510749f2088b259ef34)</span></li>
<li>libs/imageproperties/imagedescedittab.cpp <span style="color: grey">(d607c73ae4a4c19074f18539be8e785fd3110b5f)</span></li>
<li>libs/imageproperties/imagepropertiessidebar.h <span style="color: grey">(f6703339fc2e1a5762f8db898e7ad69dddab7868)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108382/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>