<html><head></head><body class="ApplePlainTextBody" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div class="AppleOriginalContents"><div>On Jan 11, 2013, at 3:59 AM, Benjamin Girault <benjamin.girault@gmail.com> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi,<br><br>2013/1/11 Gilles Caulier <caulier.gilles@gmail.com>:<br><blockquote type="cite"><br>2013/1/10 <bkn@ithryn.net><br><blockquote type="cite"><br> * digikam-sc/extra/kipi-plugins/CMakeLists.txt<br> - IF(FLEX_FOUND AND BISON_FOUND)<br> + IF(FLEX_FOUND AND BISON_FOUND AND FLEX_TARGET AND BISON_TARGET)<br><br><br>The last change is needed because the cmake modules installed through<br>MacPorts must be a little old so the FLEX_TARGET and BISON_TARGET marcos<br>are<br>not defined whereas the FLEX_FOUND and BISON_FOUND are defined; so cmake<br>will<br>eventually fail when trying to use FLEX_TAGET and BISON_TARGET marcos.<br><br></blockquote><br>This is the recent changes for Panorama tools does by Benjamin Girault. I<br>will CC him to review it (i'm not sure that he is in this ML)<br></blockquote><br>I am receiving emails from the ml digikam-dev.<br><br>About the CMakeLists.txt, it looks like a bug in FindFLEX.cmake and<br>FindBISON.cmake on MacOS. My opinion is that this patch is safe.<br><br>One question though: which version of cmake are you using? This is<br>important because the two previous files are installed by cmake.<br><br></div></blockquote><div class="AppleOriginalContents"><br><div>Benjamin -- just updated to cmake 2.8.10 from macports. I looked at the situation in more detail; here's what's happening. </div><div><br></div><div>There are two FindFlex.cmake files installed using macports, one from the cmake package (/opt/local/share/cmake-2.8/modules) and one from kdelibs4 package (/opt/local/share/cmake/modules).</div><div>For some reason cmake is always using the the one installed by the kdelibs4 package and not the one from the cmake package even if i list the cmake modules directory first with the -DCMAKE_MODULE_PATH argument. I'm not a cmake guru so i might be doing something wrong. I put a FATAL_WARNING in the kde FindFlex.cmake file to get a call stack and i got the following:</div></div><div class="AppleOriginalContents"><br></div><div class="AppleOriginalContents">CMake Error at /opt/local/share/apps/cmake/modules/FindFLEX.cmake:17 (message):<br> Using kdelibs flex.cmake<br>Call Stack (most recent call first):<br> /opt/local/share/apps/cmake/modules/MacroOptionalFindPackage.cmake:32 (find_package)<br> extra/kipi-plugins/CMakeLists.txt:169 (MACRO_OPTIONAL_FIND_PACKAGE)<br><br>If i move the FindFlex.cmake file provided by kdelibs out of the way, cmake runs fine. </div><div class="AppleOriginalContents"><br></div><div class="AppleOriginalContents">I'm not sure how to solve this cleanly at the moment w/o pano being disabled on osx since cmake will never use the proper FineFlex.cmake file. it seems that the proper solution would be to remove the FindFlex.cmake file form kdelibs since it appears to be distributed with cmake anyway. i don't know who controls the distribution files of kdelibs. </div><div class="AppleOriginalContents"><br></div><div class="AppleOriginalContents">Cheers,</div><div class="AppleOriginalContents"> -- brad</div><div class="AppleOriginalContents"><br><br></div></div><br></body></html>