<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107252/">http://git.reviewboard.kde.org/r/107252/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alexander,
I review you code, and all compile fine. Code is right for me. Feel free to commit your code into digiKam from git/master
NOTE: don't forget to patch imageplugins/TODO file about colorfx tool status.
Thanks in advance
Gilles Caulier</pre>
<br />
<p>- Gilles</p>
<br />
<p>On November 8th, 2012, 2:07 p.m., Alexander Dymo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Alexander Dymo.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2012, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm post-processing my photos with Digikam and recently wanted to apply Vivid color filter with batch queue manager. Found that it's not yet possible, so... here's the patch :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested it on my Honeymoon photos, so at least you can trust me it doesn't eat your data:) I've tested manually both color effects tool and batch queue manager filter. There should be no changes to color effects tool behavior.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1e7a255)</span></li>
<li>imageplugins/filters/colorfxtool.h <span style="color: grey">(07d1e3a)</span></li>
<li>imageplugins/filters/colorfxtool.cpp <span style="color: grey">(10a3d67)</span></li>
<li>libs/dimg/filters/fx/colorfxfilter.h <span style="color: grey">(2cbd6cc)</span></li>
<li>libs/dimg/filters/fx/colorfxfilter.cpp <span style="color: grey">(ee8dd3f)</span></li>
<li>libs/dimg/filters/fx/colorfxsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/dimg/filters/fx/colorfxsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/CMakeLists.txt <span style="color: grey">(8bc505d)</span></li>
<li>utilities/queuemanager/basetools/filters/colorfx.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/basetools/filters/colorfx.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/manager/batchtoolsmanager.cpp <span style="color: grey">(0f5ef8c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107252/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>