On 5/21/06, <b class="gmail_sendername">Caulier Gilles</b> <<a href="mailto:caulier.gilles@kdemail.net">caulier.gilles@kdemail.net</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Well, still todo... yes?</blockquote><div><br>
Yep, Can we do it when the need is felt ? As of now I don't know if any
kipi-plugin needs functionality to write Attributes for an image in to
digikam database.<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Albumdb class has a new method now, called getImageId(album Id, path) for<br>
> the reasons discussed earlier.<br><br>ok. have you tested your code with a plugin ? Have you checked your<br>implementation using valgrind (to be sure of course (:=))) ?</blockquote><div><br>
Yes, I tested with my own copy of flickrexport. Done some export, but
before I can commit the latest flickrexport I have to make some GUI
changes to flickrexport, which I will carry on once the code is
approved. :)<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Sorry i didn't know how to do CCMAIL in commit mesg, next time I would do<br>
> that.<br><br>look here on the bottom of the page :<br><br><a href="http://developer.kde.org/policies/commitpolicy.html">http://developer.kde.org/policies/commitpolicy.html</a><br><br>Thanks for your help<br><br>Gilles
</blockquote><div><br>
regards,<br>
Vardhman <br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">><br>> Vardhman<br>><br>> On 5/9/06, Vardhman Jain <<a href="mailto:vardhman@gmail.com">
vardhman@gmail.com</a>> wrote:<br>> > Hi,<br>> > There is something extra which I guess needs to be discussed. Most<br>> > of the methods in KipiInterface just use albumDB interface to fetch/set
<br>> > some data about the photo in the database. This construction doesn't<br>> > basically allow some temporary data storage which might be required for<br>> > the session purposes only, let me explain.
<br>> ><br>> > If the user says he wants to upload the photos to flickr and wants to add<br>> > some extra tags to the photos when they are uploaded to flickr and<br>> > doesn't want to effect his original tags in digikam database. We cannot
<br>> > use AlbumDB object here to store the temporary information.<br>> ><br>> > The solution in my opinion is to allow a<br>> > DigikamImageInfo::QMap<QString,QVariant> attributes; member in the
<br>> > DigikamImageInfo to allow saving of data temporarily in the object using<br>> > addAttributes() by the host application, while using attributes() from<br>> > the plugin code to obtain the data ?<br>
> ><br>> > Please let me know ur viewpoints...<br>> ><br>> > Vardhman<br>> ><br>> > On 5/8/06, Caulier Gilles < <a href="mailto:caulier.gilles@kdemail.net">caulier.gilles@kdemail.net
</a>> wrote:<br>> > > Le Samedi 06 Mai 2006 11:46 AM, Vardhman Jain a écrit:<br>> > > > Hi,<br>> > > > I am trying to hack in to the kipiinterface.cpp/.h files for<br>> > >
<br>> > > adding<br>> > ><br>> > > > some functionality to the attributes/setAttributes etc functions. I<br>> > ><br>> > > have<br>> > ><br>> > > > some doubts whose clarfification will help me a great deal.
<br>> > ><br>> > > You want said these methods :<br>> > ><br>> > > QMap<QString,QVariant> DigikamImageInfo::attributes()<br>> > > void DigikamImageInfo::clearAttributes()
<br>> > > void DigikamImageInfo::addAttributes( const QMap<QString,QVariant>& )<br>> > ><br>> > > right ?<br>> > ><br>> > > > The function Albumdb->getItemTagNames( ImageId id) takes an image
<br>> > > > id<br>> > ><br>> > > as<br>> > ><br>> > > > an argument, while almost all other functions mostly use a<br>> > > > combination<br>> > ><br>
> > > of<br>> > ><br>> > > > Album id and photo Url.<br>> > > > There are some functions which work on ImageId but they are not at<br>> > > > all<br>> > ><br>
> > > used<br>> > ><br>> > > > in implementation.<br>> > > ><br>> > > > As far as I can see there is no easy way to obtain an ImageId given a<br>> > > > DigikamImageInfo object. Therefore I would like to ask if it would be
<br>> > ><br>> > > okay<br>> > ><br>> > > > to add another method in albumDb interface to allow seeking the tag<br>> > ><br>> > > info by<br>> > ><br>> > > > combination of AlbumId and imageURL or a function should be added to
<br>> > ><br>> > > return<br>> > ><br>> > > > the imageId of a image given its AlbumId and imageURL in the albumDB<br>> > ><br>> > > file<br>> > ><br>> > > > again ?
<br>> > ><br>> > > Yes, you can do it. Just overload the current methods and don't touch<br>> > > the<br>> > > current implementation. Like this you don't unbreak the tests released<br>
> > > on<br>> > > this methods for 0.9.0 release.<br>> > ><br>> > > Please, add comments in method headers, like others current methods<br>> > > using<br>> > > Doxygen syntax.
<br>> > ><br>> > > When you commit, please CCMAIL on <a href="mailto:digikam-devel@kde.org">digikam-devel@kde.org</a> . Thanks in<br>> > > advance...<br>> > ><br>> > > Gilles<br>
> > > _______________________________________________<br>> > > Digikam-devel mailing list<br>> > > <a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br>> > > <a href="https://mail.kde.org/mailman/listinfo/digikam-devel">
https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>> ><br>> > --<br>> > Blogs: <a href="http://vardhman.blogspot.com">http://vardhman.blogspot.com</a><br>_______________________________________________
<br>Digikam-devel mailing list<br><a href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/digikam-devel">https://mail.kde.org/mailman/listinfo/digikam-devel</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Blogs: <a href="http://vardhman.blogspot.com">http://vardhman.blogspot.com</a><br>