<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Renchi,<br>
<br>
this patch fixed the problem!<br>
<br>
By the way, how do i remove a patch? Cause i don't know i had to remove
my whole digikam source directory and unpack the tarball again before i
could apply the new patch<br>
<br>
Oliver<br>
<br>
Renchi Raju wrote:
<blockquote
cite="midPine.LNX.4.61.0506191430070.16863@pooh.tam.uiuc.edu"
type="cite"><br>
duh.... i forgot that recently a patch was applied from gphoto2
upstream in gpiface.cpp. and it causes an invalid pointer reference and
so a crash. i don't have a gphoto2 supported camera anymore and so
never saw the bug.
<br>
<br>
Oliver, i have attached an updated patch which fixes this bug
(hopefully). can you try it out? you will need to remove the previous
patch.
<br>
<br>
renchi<br>
<pre wrap="">
<hr size="4" width="90%">
Index: utilities/setup/gpiface.cpp
===================================================================
--- utilities/setup/gpiface.cpp (revision 426554)
+++ utilities/setup/gpiface.cpp (working copy)
@@ -57,17 +57,35 @@
return -1;
}
- for (int i = 0; i < count; i++) {
- gp_list_get_name (camList, i, &camModel_);
- gp_list_get_value (camList, i, &camPort_);
+ camModel_ = 0;
+ camPort_ = 0;
+
+ for (int i = 0; i < count; i++)
+ {
+ if (gp_list_get_name (camList, i, &camModel_) != GP_OK)
+ {
+ gp_list_free (camList);
+ return -1;
+ }
+
+ if (gp_list_get_value (camList, i, &camPort_) != GP_OK)
+ {
+ gp_list_free (camList);
+ return -1;
+ }
+
+ if (camModel_ && camPort_)
+ {
+ model = QString::fromLatin1(camModel_);
+ port = QString::fromLatin1(camPort_);
+ gp_list_free (camList);
+ return 0;
+ }
}
gp_list_free (camList);
- model = camModel_;
- port = camPort_;
-
- return 0;
+ return -1;
}
void GPIface::getSupportedCameras(int& count, QStringList& clist)
</pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
Digikam-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Digikam-devel@kde.org">Digikam-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/digikam-devel">https://mail.kde.org/mailman/listinfo/digikam-devel</a>
</pre>
</blockquote>
</body>
</html>