[Digikam-devel] Re: extragear/graphics/digikam/libs/dmetadata

[Johannes Wienke]

Hey,

just a remark from a developer with no time left for digiKam. ;) We
should really think about extracting these exif tag rules in an external
file that is parsed at runtime. This is configuration knowledge that
should be easily changeable without recompiling digikam.

Regards,
Johannes

Am 30.09.2010 16:03 schrieb Gilles Caulier:
> SVN commit 1181246 by cgilles:
> 
> improve lens detection. add Sony id tag.
> 
> 
>  M  +2 -1      dmetadata.cpp  
> 
> 
> --- trunk/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp #1181245:1181246
> @@ -971,6 +971,7 @@
>      lensExifTags.append("Exif.NikonLd2.LensIDNumber"); // Nikon Cameras Makernote.
>      lensExifTags.append("Exif.NikonLd3.LensIDNumber"); // Nikon Cameras Makernote.
>      lensExifTags.append("Exif.Minolta.LensID");        // Minolta Cameras Makernote.
> +    lensExifTags.append("Exif.Sony1.LensID");          // Sony Cameras Makernote.
>      lensExifTags.append("Exif.Sony2.LensID");          // Sony Cameras Makernote.
>      lensExifTags.append("Exif.Pentax.LensType");       // Pentax Cameras Makernote.
>      lensExifTags.append("Exif.Panasonic.0x0051");      // Panasonic Cameras Makernote.
> @@ -992,7 +993,7 @@
>      {
>          lens = getExifTagString((*it).toAscii());
>          if ( !lens.isEmpty() &&
> -             !lens.startsWith('(') && !lens.endsWith(')') )   // To prevent undecoded tag values from Exiv2 as "(65535)".
> +             !(lens.startsWith('(') && lens.endsWith(')')) )   // To prevent undecoded tag values from Exiv2 as "(65535)".
>              return lens;
>      }
>  


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20100930/a5a3fd5a/attachment.sig>