<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Vlad,<br>
<br>
Indeed I dit not get your previous welcome message. I'll go check
the archives :)<br>
<br>
The "do not classify your reviewed commit" policy makes perfect
sense indeed. Maybe adding it to the help/wiki would be a good idea.
I will not do that anymore now.<br>
<br>
And about the commit you mention … I agree with you. I validated it
by mistake and, like I've said in my previous email, I'm not able to
delete it, it does not work for me.<br>
<br>
Thank you for your help!<br>
Gaël<br>
<br>
Le 04/10/2011 19:29, Vladislav Blanton a écrit :
<blockquote
cite="mid:CAPdjkZVdpFMH9iuEM6UhB+21907bXRrD6GP5BgHiLGekAuP6ww@mail.gmail.com"
type="cite">Hello Gaël and Welcome!<br>
<br>
I am not sure if you saw my previous welcome email to you, which I
sent to the list, but once again, welcome!<br>
<br>
Great work hammering away at the excess commits. So that you know,
in general we do not classify our own commits that we reviewed,
unless there is a time crunch involved. Especially since you just
started doing this, it is good if we can double check the commits
you chose before they are classified (and thus part of the
digest).<br>
<br>
As an example:<br>
----------------<br>
<div class="commit-title">Commit <i
id="r::1e16b68a9eba0f9ea85db82f7d03e071be4eac1a"
class="revision">1e16b68...</i> by <span>Frank Reininghaus</span>
(<span>freininghaus</span>) <br>
[kde-baseapps] /src </div>
<div class="commit-msg"> <span>Add function
KItemListSelectionManager::isSelected(int index)<br>
<br>
This function is used in
KItemListView::updateWidgetProperties()<br>
to find out if an item is selected in a more efficient way.<br>
The new function is tested in KItemListSelectionManagerTest.<br>
I've factored out some code from<br>
KItemListSelectionManagerTest::testChangeSelection() to a new<br>
member to simplify the test.<br>
----------------<br>
</span> </div>
This commit is not a very interesting feature, bug fix, or
optimization.<br>
<br>
thanks for the good work!<br>
<br>
Vlad<br>
<br>
<br>
<br>
<div class="gmail_quote">
On Tue, Oct 4, 2011 at 9:23 AM, Gaël Beaudoin <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:gaboo@gaboo.org">gaboo@gaboo.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi,
<div><br>
</div>
<div>I've just started contributing to the commit digest using
enzyme. After reading it since the first edition and also
reading commits and various kde mailing list, I've finally
jumped in to help.</div>
<div><br>
</div>
<div>The tool is easy to use and fast so that reviewing does
not takes too much time :)</div>
<div><br>
</div>
<div>I still have two small bugs : </div>
<div>* I often am not able to save the first commit in the
review list. For instance, there is only one left now, that
i'd like to approve and classify, but when saving I get
"save unsuccessful" message. When in a batch of several
commits, the state is not saved either.</div>
<div>* in the classify section, I'm not able to delete a
commit. I've just tried again. I click the red cross, click
ok in the dialog and nothing happens, even if I click save
afterwards.</div>
<div><br>
</div>
<div>
Those two bugs happen with both firefox 7 and chrome 13 btw.</div>
<div><br>
</div>
<div>I hope I'm not complaining too much already :D</div>
<div><br>
</div>
<div>Have a nice day!</div>
<div>Gaël</div>
<font color="#888888">
<div>
<br>
</div>
<div><br>
</div>
</font><br>
_______________________________________________<br>
Digest mailing list<br>
<a moz-do-not-send="true" href="mailto:Digest@kde.org">Digest@kde.org</a><br>
<a moz-do-not-send="true"
href="https://mail.kde.org/mailman/listinfo/digest"
target="_blank">https://mail.kde.org/mailman/listinfo/digest</a><br>
<br>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>