<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121652/">https://git.reviewboard.kde.org/r/121652/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix the things Andrea reported, and it's fine to me too.
Thanks.</p></pre>
<br />
<p>- Mehrdad Momeny</p>
<br />
<p>On December 23rd, 2014, 6:54 p.m. UTC, Ian Schwarz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok.</div>
<div>By Ian Schwarz.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2014, 6:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For "Posts from $USER", Choqok should use Twitter's "statuses/user_timeline.json" API instead of the "search/tweets.json" API it uses for everything else. The reason for this is that the search API is not exhaustive (i.e. it does not necessarily return ALL tweets by a user) and will, in any case, only return tweets that are 7 days old (or newer). The "statuses/user_timeline.json" API returns up to 3,200 tweets of any age.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also https://reviewboard.kde.org/r/121165/.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and works for me, although I have only tested it briefly in this "modular" form. Testing it is rather hard because it is impossible to browse pages/display older tweets, so you have to test it with an account that has tweeted less than 100 times (max. number of results) in the last 7 days (to see if it will display older tweets).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also https://reviewboard.kde.org/r/121165/.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>choqok-vanilla/microblogs/twitter/twittersearch.h <span style="color: grey">(662e8d7)</span></li>
<li>choqok-vanilla/microblogs/twitter/twittersearch.cpp <span style="color: grey">(da85565)</span></li>
<li>choqok-vanilla/microblogs/laconica/laconicasearch.h <span style="color: grey">(4bfac2d)</span></li>
<li>choqok-vanilla/microblogs/laconica/laconicasearch.cpp <span style="color: grey">(4b1c9c9)</span></li>
<li>choqok-vanilla/microblogs/twitter/twitterpostwidget.cpp <span style="color: grey">(a07b856)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.h <span style="color: grey">(b421585)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.cpp <span style="color: grey">(b3078c4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121652/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>