<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121479/">https://git.reviewboard.kde.org/r/121479/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2014, 6:47 a.m. CET, <b>Mehrdad Momeny</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121479/diff/1/?file=332960#file332960line237" style="color: black; font-weight: bold; text-decoration: underline;">microblogs/laconica/laconicaeditaccount.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">237</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ok</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think you should move this "if(!ok)" part to after the first if, and then no need for the else part.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I re-use 'ok' here. QVariant.toUInt() returns 0 when its parser fails, but also sets 'ok' to false. I'm missing something?</p></pre>
<br />
<p>- Andrea</p>
<br />
<p>On December 13th, 2014, 8:07 p.m. CET, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2014, 8:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283298">283298</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I reworked #102222.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">setCharLimit() has been moved from the MicroBlog to the Account class. It also has been renamed as setPostCharLimit().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I moved the setTextLimit function in the EditAccount widget. The change is then propagated to the ComposerWidget by the modified() signal, which listen on it and redraw the Editor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, the HTTP job result is checked and only when it fails a fixed value (140) is set; unlimited text is allowed then.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pump.IO account has been updated to the new API.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Registered an account on http://social.stopwatchingus-heidelberg.de (which has a limit on 500 chars).
Counter is correctly set without a restart and it persists after a restart.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>helperlibs/twitterapihelper/twitterapiaccount.cpp <span style="color: grey">(e2efe97)</span></li>
<li>helperlibs/twitterapihelper/twitterapicomposerwidget.cpp <span style="color: grey">(0734115)</span></li>
<li>helperlibs/twitterapihelper/twitterapidmessagedialog.cpp <span style="color: grey">(70092db)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(ff50710)</span></li>
<li>libchoqok/account.h <span style="color: grey">(de56ddf)</span></li>
<li>libchoqok/account.cpp <span style="color: grey">(7674c52)</span></li>
<li>libchoqok/microblog.h <span style="color: grey">(4c46199)</span></li>
<li>libchoqok/microblog.cpp <span style="color: grey">(fd9a1f9)</span></li>
<li>libchoqok/ui/composerwidget.cpp <span style="color: grey">(79603eb)</span></li>
<li>libchoqok/ui/quickpost.cpp <span style="color: grey">(0d1deb5)</span></li>
<li>microblogs/laconica/CMakeLists.txt <span style="color: grey">(5516c2b)</span></li>
<li>microblogs/laconica/laconicacomposerwidget.h <span style="color: grey">(59b354d)</span></li>
<li>microblogs/laconica/laconicacomposerwidget.cpp <span style="color: grey">(024b9f2)</span></li>
<li>microblogs/laconica/laconicaeditaccount.h <span style="color: grey">(c4a1c90)</span></li>
<li>microblogs/laconica/laconicaeditaccount.cpp <span style="color: grey">(9ad5470)</span></li>
<li>microblogs/pumpio/pumpioaccount.cpp <span style="color: grey">(8cf74e4)</span></li>
<li>microblogs/pumpio/pumpiocomposerwidget.cpp <span style="color: grey">(53a11bc)</span></li>
<li>microblogs/pumpio/pumpiomicroblog.cpp <span style="color: grey">(98c4009)</span></li>
<li>microblogs/twitter/twittercomposerwidget.cpp <span style="color: grey">(e04a9f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121479/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>