<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118535/">https://git.reviewboard.kde.org/r/118535/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are two small issues, fix them and It will be OK to ship ;)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118535/diff/3/?file=283721#file283721line195" style="color: black; font-weight: bold; text-decoration: underline;">helperlibs/twitterapihelper/twitterapimicroblog.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">195</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="nf">slotRequestFriendsScreenName</span><span class="p">(</span> <span class="n">KJob</span> <span class="o">*</span><span class="n">job</span><span class="p">,</span> <span class="kt">bool</span> <span class="n">active</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This function is no longer a slot! so it would be better to move it to the non-slot part of definitions. please correct me if I'm wrong.
Also I think it shouldn't be a virtual function.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118535/diff/3/?file=283724#file283724line264" style="color: black; font-weight: bold; text-decoration: underline;">microblogs/laconica/laconicamicroblog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LaconicaMicroBlog::requestFriendsScreenName(TwitterApiAccount* theAccount)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LaconicaMicroBlog::requestFriendsScreenName(TwitterApiAccount* theAccount, bool active)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">264</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">LaconicaMicroBlog</span><span class="o">::</span><span class="n">slotRequestFriendsScreenName</span><span class="p">(</span><span class="n">KJob</span><span class="o">*</span> <span class="n">job</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">264</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">LaconicaMicroBlog</span><span class="o">::</span><span class="n">slotRequestFriendsScreenName</span><span class="p">(</span><span class="n">KJob</span><span class="o">*</span> <span class="n">job</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">active</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this will break the connect query in line 260.
And since this is a local signal/slot connection, there's no need to change this function in LaconicaMicroBlog!</pre>
</div>
<br />
<p>- Mehrdad Momeny</p>
<br />
<p>On June 22nd, 2014, 7:46 p.m. UTC, Yuen Hoe Lim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Choqok and Mehrdad Momeny.</div>
<div>By Yuen Hoe Lim.</div>
<p style="color: grey;"><i>Updated June 22, 2014, 7:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If choqok is started without internet connection, a pop up shows up saying "Friends list for account could not be updated", which is a little annoying since the status bar already has a similar error message - especially during start up where I always need to close the pop up as the first thing I do after logging into Plasma when there's no internet. Thought I'd try and investigate the code and I found it's because the friend list update error is, unlike other errors like failure to update timeline, emitted with severity "Critical". Changing this to "Low" like the others gets rid of the popup.
Is this an acceptable patch? Or is there an important reason the friends list update message is Critical? If so, then is there another better way I could patch choqok to avoid the pop up?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>helperlibs/twitterapihelper/twitterapimicroblog.h <span style="color: grey">(e0765b2)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(317f14b)</span></li>
<li>microblogs/laconica/laconicamicroblog.h <span style="color: grey">(9d0d9e7)</span></li>
<li>microblogs/laconica/laconicamicroblog.cpp <span style="color: grey">(7bdbd2d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118535/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>