<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112171/">http://git.reviewboard.kde.org/r/112171/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9483d81a9e820ce5f22b3ad766ac9bb598943f17 by Lim Yuen Hoe to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 20th, 2013, 7:59 a.m. UTC, Yuen Hoe Lim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Choqok and Mehrdad Momeny.</div>
<div>By Yuen Hoe Lim.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2013, 7:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Performing a search on choqok "saves" it as a new tab, in the sense that as long as the tab isn't manually closed, the search results continue to be updated, and they also get reloaded if you exit and start choqok again. However, if choqok is started when there is no internet connection, the search tabs aren't created, meaning the saved searches are lost and won't come back even after internet connection is restored. I think this qualifies as buggy behavior, and so this is a small patch to address that.
All it does is it makes sure to still create the saved search tabs (with no results) even when there is no internet connection. This prevents the tabs from becoming lost, and the search results are automatically loaded in when internet connection is later restored.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple testing on my machine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>microblogs/twitter/twittersearch.cpp <span style="color: grey">(dee43b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112171/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>