<table><tr><td style="">leinir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26221">View Revision</a></tr></table><br /><div><div><p>That's looking pretty good, really :) Also code reduction is certainly good ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26221#inline-147673">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Dialog.qml:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #004012"><span class="bright">Rectangle</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">id: progressBase</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">opacity:</span> <span class="p">(</span><span style="color: #004012">progress</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">progressBar</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">Behavior</span> <span style="color: #004012">on</span> <span style="color: #004012">opacity</span> <span class="p">{</span> <span style="color: #004012">NumberAnimation</span> <span class="p">{</span> <span style="color: #aa4000">duration:</span> <span style="color: #004012">Constants</span><span class="p">.</span><span style="color: #004012">AnimationDuration</span><span class="p">;</span> <span class="p">}</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">top:</span> <span style="color: #004012">dialogText</span><span class="p">.</span><span style="color: #004012">bottom</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">margins:</span> <span style="color: #601200">8</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">height:</span> <span style="color: #004012">Constants</span><span class="p">.</span><span style="color: #004012">LargeFontSize</span> <span style="color: #aa2211">+</span> <span style="color: #601200">4</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">width:</span> <span style="color: #601200">208</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">radius:</span> <span style="color: #004012">height</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">border</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">width:</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">Settings</span><span class="p">.</span><span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">color</span><span class="p">(</span><span style="color: #766510">"components/dialog/progress/border"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">Settings</span><span class="p">.</span><span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">color</span><span class="p">(</span><span style="color: #766510">"components/dialog/progress/background"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">Rectangle</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">id: progressBar</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">top:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">top</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">left:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">left</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">margins:</span> <span style="color: #601200">4</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">radius:</span> <span style="color: #004012">height</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">width:</span> <span style="color: #004012">progress</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span class="p">(</span><span style="color: #004012">progress</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #601200">100</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">height:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #601200">7</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">Behavior</span> <span style="color: #004012">on</span> <span style="color: #004012">width</span> <span class="p">{</span> <span style="color: #004012">PropertyAnimation</span> <span class="p">{</span> <span style="color: #aa4000">duration:</span> <span style="color: #601200">100</span><span class="p">;</span> <span class="p">}</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">Settings</span><span class="p">.</span><span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">color</span><span class="p">(</span><span style="color: #766510">"components/dialog/progress/bar"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #004012"><span class="bright">QQC2</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">BusyIndicator</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">running:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">base</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">enabled</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Thinking this wants to be centered... or if that means things end up looking lop-sided, perhaps have it right-aligned? As it stands, it looks kind of... very heavy on the left hand side.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26221">https://phabricator.kde.org/D26221</a></div></div><br /><div><strong>To: </strong>ognarb, Calligra: 3.0, leinir<br /><strong>Cc: </strong>Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever<br /></div>