<table><tr><td style="">ognarb created this revision.<br />Herald added a project: Calligra: 3.0.<br />Herald added a subscriber: Calligra-Devel-list.<br />ognarb requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25560">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Reduce significantly the number of warnings during compilation</li>
<li class="remarkup-list-item">Only manual intervention was in filters/sheets/excel/sidewinder/recordsxml2cpp.cpp</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25560">https://phabricator.kde.org/D25560</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>components/CalligraComponentsPlugin.h<br />
components/Document.h<br />
components/ImageDataItem.h<br />
components/LinkArea.h<br />
components/View.h<br />
components/ViewController.h<br />
components/impl/ComponentsKoCanvasController.h<br />
components/impl/DocumentImpl.h<br />
components/impl/PresentationImpl.h<br />
components/impl/PresentationKoPAView.h<br />
components/impl/SpreadsheetImpl.h<br />
components/impl/TextDocumentImpl.h<br />
components/models/ContentsModel.h<br />
components/models/PresentationContentsModelImpl.h<br />
components/models/SpreadsheetContentsModelImpl.h<br />
components/models/TextContentsModelImpl.h<br />
devtools/cstester/CSThumbProviderKarbon.h<br />
devtools/cstester/CSThumbProviderStage.h<br />
devtools/cstester/CSThumbProviderTables.h<br />
devtools/cstester/CSThumbProviderWords.h<br />
devtools/cstester/cstrunner/CSTProcessRunner.h<br />
devtools/cstester/visualimagecompare/CSTCompareView.h<br />
devtools/cstester/visualimagecompare/CompareView.h<br />
extras/thumbnail/calligracreator.h<br />
filters/karbon/eps/EpsImport.h<br />
filters/karbon/eps/PsCommentLexer.h<br />
filters/karbon/image/ImageExport.h<br />
filters/karbon/karbon1.x/Karbon1xImport.h<br />
filters/karbon/pdf/Pdf2OdgImport.h<br />
filters/karbon/pdf/PdfImport.h<br />
filters/karbon/pdf/SvgOutputDev.h<br />
filters/karbon/svg/SvgExport.h<br />
filters/karbon/svg/SvgImport.h<br />
filters/karbon/wmf/WmfExport.h<br />
filters/karbon/wmf/WmfImport.h<br />
filters/karbon/wmf/WmfImportParser.h<br />
filters/karbon/wpg/WPGImport.h<br />
filters/karbon/xfig/XFigDocument.h<br />
filters/karbon/xfig/XFigImportFilter.h<br />
filters/libmso/generated/leinputstream.h<br />
filters/libmsooxml/KoOdfExporter.h<br />
filters/libmsooxml/MsooXmlCommonReader.h<br />
filters/libmsooxml/MsooXmlDiagramReader.h<br />
filters/libmsooxml/MsooXmlDiagramReader_p.h<br />
filters/libmsooxml/MsooXmlDocPropertiesReader.h<br />
filters/libmsooxml/MsooXmlDrawingTableStyle.h<br />
filters/libmsooxml/MsooXmlDrawingTableStyleReader.h<br />
filters/libmsooxml/MsooXmlImport.h<br />
filters/libmsooxml/MsooXmlRelationshipsReader.h<br />
filters/libmsooxml/MsooXmlTheme.h<br />
filters/libmsooxml/MsooXmlThemesReader.h<br />
filters/libmsooxml/VmlDrawingReader.h<br />
filters/libodf2/KoCellStyle.h<br />
filters/libodf2/KoColumnStyle.h<br />
filters/libodf2/KoDummyCellValue.h<br />
filters/libodf2/KoOdfGraphicProperties.h<br />
filters/libodf2/KoOdfHeaderFooterProperties.h<br />
filters/libodf2/KoOdfListLevelProperties.h<br />
filters/libodf2/KoOdfPageLayout.h<br />
filters/libodf2/KoOdfPageLayoutProperties.h<br />
filters/libodf2/KoOdfParagraphProperties.h<br />
filters/libodf2/KoOdfStyle.h<br />
filters/libodf2/KoOdfTextProperties.h<br />
filters/libodf2/KoRawCellChild.h<br />
filters/libodf2/KoRowStyle.h<br />
filters/libodf2/KoTblStyle.h<br />
filters/libodf2/chart/Charting.h<br />
filters/libodfreader/OdsReader.h<br />
filters/libodfreader/OdsReaderBackend.h<br />
filters/libodfreader/OdtReader.h<br />
filters/libodfreader/OdtReaderBackend.h<br />
filters/odg/visio/import/VSDXImport.cpp<br />
filters/odg/wpg/import/WPGImport.cpp<br />
filters/outputhelper/StringDocumentHandler.hxx<br />
filters/sheets/applixspread/applixspreadimport.h<br />
filters/sheets/csv/csvexport.h<br />
filters/sheets/csv/csvexportdialog.h<br />
filters/sheets/csv/csvimport.h<br />
filters/sheets/dbase/dbaseimport.h<br />
filters/sheets/excel/export/CFBWriter.cpp<br />
filters/sheets/excel/export/ExcelExport.h<br />
filters/sheets/excel/import/ExcelImport.h<br />
filters/sheets/excel/import/ODrawClient.h<br />
filters/sheets/excel/import/excelimporttoods.h<br />
filters/sheets/excel/sidewinder/chartsubstreamhandler.cpp<br />
filters/sheets/excel/sidewinder/chartsubstreamhandler.h<br />
filters/sheets/excel/sidewinder/excel.h<br />
filters/sheets/excel/sidewinder/globalssubstreamhandler.h<br />
filters/sheets/excel/sidewinder/objects.h<br />
filters/sheets/excel/sidewinder/recordsxml2cpp.cpp<br />
filters/sheets/excel/sidewinder/workbook.h<br />
filters/sheets/excel/sidewinder/worksheetsubstreamhandler.h<br />
filters/sheets/excel/sidewinder/xmltk.h<br />
filters/sheets/gnumeric/gnumericexport.h<br />
filters/sheets/gnumeric/gnumericimport.h<br />
filters/sheets/html/exportdialog.h<br />
filters/sheets/html/htmlexport.h<br />
filters/sheets/latex/export/cell.h<br />
filters/sheets/latex/export/column.h<br />
filters/sheets/latex/export/document.h<br />
filters/sheets/latex/export/fileheader.h<br />
filters/sheets/latex/export/format.h<br />
filters/sheets/latex/export/latexexport.h<br />
filters/sheets/latex/export/latexexportAdaptor.h<br />
filters/sheets/latex/export/latexexportdialog.h<br />
filters/sheets/latex/export/map.h<br />
filters/sheets/latex/export/pen.h<br />
filters/sheets/latex/export/row.h<br />
filters/sheets/latex/export/spreadsheet.h<br />
filters/sheets/latex/export/table.h<br />
filters/sheets/opencalc/opencalcexport.h<br />
filters/sheets/opencalc/opencalcimport.h<br />
filters/sheets/qpro/qproimport.h<br />
filters/sheets/xlsx/XlsxChartOdfWriter.h<br />
filters/sheets/xlsx/XlsxImport.h<br />
filters/sheets/xlsx/XlsxXmlChartReader.h<br />
filters/sheets/xlsx/XlsxXmlCommentsReader.h<br />
filters/sheets/xlsx/XlsxXmlCommonReader.h<br />
filters/sheets/xlsx/XlsxXmlDocumentReader.h<br />
filters/sheets/xlsx/XlsxXmlDrawingReader.h<br />
filters/sheets/xlsx/XlsxXmlSharedStringsReader.h<br />
filters/sheets/xlsx/XlsxXmlStylesReader.h<br />
filters/sheets/xlsx/XlsxXmlTableReader.h<br />
filters/sheets/xlsx/XlsxXmlWorksheetReader.h<br />
filters/sheets/xlsx/XlsxXmlWorksheetReader_p.h<br />
filters/stage/keynote/import/KeyImport.cpp<br />
filters/stage/keynote/import/KeyImport.h<br />
filters/stage/kpr2odf/Filterkpr2odf.h<br />
filters/stage/powerpoint/PowerPointImport.h<br />
filters/stage/powerpoint/PptToOdp.cpp<br />
filters/stage/pptx/PptxImport.h<br />
filters/stage/pptx/PptxXmlCommentAuthorsReader.h<br />
filters/stage/pptx/PptxXmlCommentsReader.h<br />
filters/stage/pptx/PptxXmlDocumentReader.h<br />
filters/stage/pptx/PptxXmlSlideReader.h<br />
filters/words/applixword/applixwordimport.h<br />
filters/words/ascii/AsciiExport.h<br />
filters/words/ascii/AsciiImport.h<br />
filters/words/ascii/ImportDialog.h<br />
filters/words/ascii/OdfReaderAsciiContext.h<br />
filters/words/ascii/OdtReaderAsciiBackend.h<br />
filters/words/docx/export/DocxExport.h<br />
filters/words/docx/export/DocxFile.h<br />
filters/words/docx/export/OdfReaderDocxContext.h<br />
filters/words/docx/export/OdfTextReaderDocxBackend.h<br />
filters/words/docx/export/OdtReaderDocxBackend.h<br />
filters/words/docx/import/DocxImport.h<br />
filters/words/docx/import/DocxXmlCommentsReader.h<br />
filters/words/docx/import/DocxXmlDocumentReader.h<br />
filters/words/docx/import/DocxXmlEndnoteReader.h<br />
filters/words/docx/import/DocxXmlFontTableReader.h<br />
filters/words/docx/import/DocxXmlFooterReader.h<br />
filters/words/docx/import/DocxXmlFootnoteReader.h<br />
filters/words/docx/import/DocxXmlHeaderReader.h<br />
filters/words/docx/import/DocxXmlNumberingReader.h<br />
filters/words/docx/import/DocxXmlSettingsReader.h<br />
filters/words/docx/import/DocxXmlStylesReader.h<br />
filters/words/epub/EpubFile.h<br />
filters/words/epub/HtmlFile.h<br />
filters/words/epub/exportepub2.h<br />
filters/words/epub/exporthtml.h<br />
filters/words/mobi/exportmobi.h<br />
filters/words/msword-odf/document.h<br />
filters/words/msword-odf/exceptions.h<br />
filters/words/msword-odf/graphicshandler.h<br />
filters/words/msword-odf/mswordodfimport.h<br />
filters/words/msword-odf/tablehandler.h<br />
filters/words/msword-odf/texthandler.h<br />
filters/words/msword-odf/wv2/src/functor.h<br />
filters/words/msword-odf/wv2/src/headers95.h<br />
filters/words/msword-odf/wv2/src/headers97.h<br />
filters/words/msword-odf/wv2/src/olestream.h<br />
filters/words/msword-odf/wv2/src/paragraphproperties.h<br />
filters/words/msword-odf/wv2/src/parser.h<br />
filters/words/msword-odf/wv2/src/parser95.h<br />
filters/words/msword-odf/wv2/src/parser97.h<br />
filters/words/msword-odf/wv2/src/parser9x.h<br />
filters/words/msword-odf/wv2/src/word95_generated.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/AuthorPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/CategoryPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/CommentPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/CompanyPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentCommentPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/FontTableDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/GeneratorPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/HLinkBasePcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/IgnoredDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/InfoCreatedTimeDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/InfoDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/InfoPrintedTimeDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/InfoRevisedTimeDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/InfoTimeDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/KeywordsPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/ManagerPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/OperatorPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/PcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/PictDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/StyleSheetDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/SubjectPcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/TitlePcdataDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/UserPropsDestination.h<br />
filters/words/rtf/import/3rdparty/rtf-qt/src/rtfreader.h<br />
filters/words/rtf/import/rtfimport.h<br />
filters/words/wiki/export/OdfReaderWikiContext.h<br />
filters/words/wiki/export/OdtReaderWikiBackend.h<br />
filters/words/wiki/export/WikiExport.h<br />
filters/words/wordperfect/import/WPDImport.cpp<br />
filters/words/wordperfect/import/WPDImport.h<br />
filters/words/works/import/WPSImport.cpp<br />
filters/words/works/import/WPSImport.h<br />
flow/part/FlowFactoryInit.h<br />
flow/part/FlowView.h<br />
gemini/CloudAccountsModel.h<br />
gemini/DocumentListModel.h<br />
gemini/DocumentManager.h<br />
gemini/KeyboardModel.h<br />
gemini/MainWindow.h<br />
gemini/ParagraphStylesModel.h<br />
gemini/ProgressProxy.h<br />
gemini/PropertyContainer.h<br />
gemini/RecentFileManager.h<br />
gemini/RecentFilesModel.h<br />
gemini/RecentImageImageProvider.h<br />
gemini/ScribbleArea.h<br />
gemini/Settings.h<br />
gemini/SimpleTouchArea.h<br />
gemini/TemplateVariantsModel.h<br />
gemini/TemplatesModel.h<br />
gemini/Theme.h<br />
gemini/ThumbnailHelperImpl.h<br />
gemini/ToolManager.h<br />
gemini/cloud/dropbox/3rdparty/filetransferitem.h<br />
gemini/cloud/dropbox/3rdparty/folderitem.h<br />
gemini/cloud/dropbox/3rdparty/listmodel.h<br />
gemini/cloud/dropbox/3rdparty/networkcontroller.h<br />
gemini/cloud/dropbox/controller.h<br />
gemini/cloud/dropbox/dropboxplugin.h<br />
gemini/desktopviewproxy.h<br />
gemini/lib/GeminiMainWindow.h<br />
karbon/KarbonFactoryInit.h<br />
karbon/common/KarbonOutlinePaintingStrategy.cpp<br />
karbon/common/KarbonOutlinePaintingStrategy.h<br />
karbon/common/commands/KarbonBooleanCommand.h<br />
karbon/main.cpp<br />
karbon/plugins/flattenpath/FlattenPathPlugin.h<br />
karbon/plugins/flattenpath/KarbonPathFlattenCommand.h<br />
karbon/plugins/refinepath/KarbonPathRefineCommand.h<br />
(1293 more files...)</div></div></div><br /><div><strong>To: </strong>ognarb<br /><strong>Cc: </strong>Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever<br /></div>