<table><tr><td style="">davidllewellynjones updated this revision to Diff 68954.<br />davidllewellynjones added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25008">View Revision</a></tr></table><br /><div><div><p>Thanks <a href="https://phabricator.kde.org/p/dcaliste/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dcaliste</a>, this is an excellent suggestion and much better naming. I've updated the diff to make the changes you suggested.</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES</li>
<li class="remarkup-list-item">MSOOXML::readonlySpreadsheet() -> MSOOXML::byValuesSpreadsheet()</li>
</ul>

</div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D25008?vs=68885&id=68954">https://phabricator.kde.org/D25008?vs=68885&id=68954</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25008">https://phabricator.kde.org/D25008</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
filters/libmsooxml/MsooXmlGlobal.cpp<br />
filters/libmsooxml/MsooXmlGlobal.h<br />
filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp<br />
filters/sheets/xlsx/XlsxXmlWorksheetReader_p.h</div></div></div><br /><div><strong>To: </strong>davidllewellynjones, Calligra: 3.0, pvuorela, dcaliste<br /><strong>Cc: </strong>Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever<br /></div>