<table><tr><td style="">leinir requested changes to this revision.<br />leinir added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23617">View Revision</a></tr></table><br /><div><div><p>Something tells me there's going to be problems on windows if this gets done... since that is the precise reason that code exists in the first place: <a href="https://phabricator.kde.org/R8:c1866b590bd6103fdf118558834104be2737cca4" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/R8:c1866b590bd6103fdf118558834104be2737cca4</a></p>
<p>however, if it could be made windows-only, that would work for me. That would likely require exposing that from MainWindow::initTouchView() (where there's already some windows detection code and such) Something like adding an osIsWindows root context property and setting that to true, and then checking for that in the if statement there in addition to the filename check, ought to do the trick.</p>
<p>Also, thanks for taking an interest in the code, it's really great to see work happening on it :D</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23617">https://phabricator.kde.org/D23617</a></div></div><br /><div><strong>To: </strong>anthonyfieroni, Calligra: 3.0, leinir<br /><strong>Cc: </strong>Calligra-Devel-list, dcaliste, cochise, vandenoever<br /></div>