<table><tr><td style="">danders added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19216">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19216#inline-107326">View Inline</a><span style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KarbonConfigInterfacePage.cpp:73-90</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">We can remove "number of recent files" since other apps does not have it. but for other 2 i don't see why we remove them, someone can found useful (somehow). About me, i want them back, recent file complete remove not commented.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I reconsiddered this, sheets actually also implements this so I'll leave it in.<br />
(It does not work properly neither for karbon nor sheets, but that for different rainy day)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19216#inline-107322">View Inline</a><span style="color: #4b4d51; font-weight: bold;">danders</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KarbonConfigInterfacePage.cpp:73-90</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Recent file & docker font:<br />
Why does karbon need these, none of the other apps have it.<br />
Personally I would remove it, alternativly implent for all apps.<br />
Canvas color:<br />
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.<br />
Also, if you have multiple views, it sets it in all views.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I also reconsidder docker font setting. It is useful and (partially) implemented in libs. You have to restart to get the new setting.<br />
This should be impleneted for all apps, but that's for a different patch.</p>
<p style="padding: 0; margin: 8px;">But, when it comes to canvas background, the more a look into it the more I dislike it.<br />
Afaics it goes against both odf spec, wysiwyg and pageapp implementation.<br />
Unfortunatly it was implemented so long ago that there is not mail archive any longer and<br />
the git log doesn't give any reason.<br />
Unless I get a *very* good reason to implement this I will not include it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19216">https://phabricator.kde.org/D19216</a></div></div><br /><div><strong>To: </strong>danders, anthonyfieroni<br /><strong>Cc: </strong>rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever<br /></div>