<table><tr><td style="">ognarb created this revision.<br />Herald added a project: Calligra: 3.0.<br />Herald added a subscriber: Calligra-Devel-list.<br />ognarb requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19132">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Use clang-tidy to:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Use default wenn possible for constructor and destructor</li>
<li class="remarkup-list-item">Use nullptr instead of 0 or NULL</li>
<li class="remarkup-list-item">Use for (type &element : list) when already using std iterator (.begin() .end() )</li>
</ul>

<p>if this patch is acepted, if will do the same for the entire calligra codebase.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19132">https://phabricator.kde.org/D19132</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
libs/widgets/KoAspectButton.h<br />
libs/widgets/KoColorPatch.h<br />
libs/widgets/KoColorPopupAction.h<br />
libs/widgets/KoColorPopupButton.cpp<br />
libs/widgets/KoColorPopupButton.h<br />
libs/widgets/KoColorSetWidget.h<br />
libs/widgets/KoColorSlider.cpp<br />
libs/widgets/KoColorSlider.h<br />
libs/widgets/KoConfigAuthorPage.h<br />
libs/widgets/KoContextBarButton.cpp<br />
libs/widgets/KoContextBarButton.h<br />
libs/widgets/KoCsvImportDialog.h<br />
libs/widgets/KoDialog.h<br />
libs/widgets/KoDialog_p.h<br />
libs/widgets/KoDockWidgetTitleBar.cpp<br />
libs/widgets/KoDockWidgetTitleBar.h<br />
libs/widgets/KoDockWidgetTitleBarButton.h<br />
libs/widgets/KoDocumentInfoDlg.cpp<br />
libs/widgets/KoDocumentInfoDlg.h<br />
libs/widgets/KoDocumentInfoPropsPage.cpp<br />
libs/widgets/KoDocumentInfoPropsPage.h<br />
libs/widgets/KoDpi.cpp<br />
libs/widgets/KoDpi.h<br />
libs/widgets/KoDualColorButton.h<br />
libs/widgets/KoEditColorSetDialog.cpp<br />
libs/widgets/KoEditColorSetDialog.h<br />
libs/widgets/KoFillConfigWidget.cpp<br />
libs/widgets/KoFillConfigWidget.h<br />
libs/widgets/KoGenericRegistryModel.h<br />
libs/widgets/KoGlobal.cpp<br />
libs/widgets/KoGradientEditWidget.cpp<br />
libs/widgets/KoGradientEditWidget.h<br />
libs/widgets/KoIconToolTip.h<br />
libs/widgets/KoItemToolTip.h<br />
libs/widgets/KoLineStyleItemDelegate_p.h<br />
libs/widgets/KoLineStyleModel_p.h<br />
libs/widgets/KoLineStyleSelector.h<br />
libs/widgets/KoMarkerItemDelegate.cpp<br />
libs/widgets/KoMarkerItemDelegate.h<br />
libs/widgets/KoMarkerModel.cpp<br />
libs/widgets/KoMarkerModel.h<br />
libs/widgets/KoMarkerSelector.cpp<br />
libs/widgets/KoMarkerSelector.h<br />
libs/widgets/KoModeBoxDocker.cpp<br />
libs/widgets/KoModeBoxDocker_p.h<br />
libs/widgets/KoModeBoxFactory.h<br />
libs/widgets/KoModeBox_p.h<br />
libs/widgets/KoPageLayoutWidget.h<br />
libs/widgets/KoPagePreviewWidget.h<br />
libs/widgets/KoPageWidgetItem.h<br />
libs/widgets/KoPositionSelector.cpp<br />
libs/widgets/KoPositionSelector.h<br />
libs/widgets/KoResourceItemChooser.h<br />
libs/widgets/KoResourceItemChooserContextMenu.cpp<br />
libs/widgets/KoResourceItemChooserContextMenu.h<br />
libs/widgets/KoResourceItemChooserSync.cpp<br />
libs/widgets/KoResourceItemChooserSync.h<br />
libs/widgets/KoResourceItemDelegate.h<br />
libs/widgets/KoResourceItemView.h<br />
libs/widgets/KoResourceModel.h<br />
libs/widgets/KoResourceModelBase.h<br />
libs/widgets/KoResourcePaths.cpp<br />
libs/widgets/KoResourcePopupAction.cpp<br />
libs/widgets/KoResourcePopupAction.h<br />
libs/widgets/KoResourceSelector.h<br />
libs/widgets/KoResourceServer.h<br />
libs/widgets/KoResourceServerAdapter.cpp<br />
libs/widgets/KoResourceServerAdapter.h<br />
libs/widgets/KoResourceServerProvider.cpp<br />
libs/widgets/KoResourceServerProvider.h<br />
libs/widgets/KoResourceTaggingManager.h<br />
libs/widgets/KoRuler.h<br />
libs/widgets/KoRulerController_p.h<br />
libs/widgets/KoRuler_p.h<br />
libs/widgets/KoShadowConfigWidget.cpp<br />
libs/widgets/KoSliderCombo.cpp<br />
libs/widgets/KoSliderCombo.h<br />
libs/widgets/KoSliderCombo_p.h<br />
libs/widgets/KoStrokeConfigWidget.cpp<br />
libs/widgets/KoStrokeConfigWidget.h<br />
libs/widgets/KoTableView.h<br />
libs/widgets/KoTagChooserWidget.h<br />
libs/widgets/KoTagFilterWidget.h<br />
libs/widgets/KoToolBox.cpp<br />
libs/widgets/KoToolBoxButton.cpp<br />
libs/widgets/KoToolBoxDocker_p.h<br />
libs/widgets/KoToolBoxFactory.cpp<br />
libs/widgets/KoToolBoxFactory.h<br />
libs/widgets/KoToolBoxLayout_p.h<br />
libs/widgets/KoToolBox_p.h<br />
libs/widgets/KoToolDocker.cpp<br />
libs/widgets/KoToolDocker.h<br />
libs/widgets/KoTriangleColorSelector.h<br />
libs/widgets/KoUnitDoubleSpinBox.h<br />
libs/widgets/KoViewItemContextBar.cpp<br />
libs/widgets/KoViewItemContextBar.h<br />
libs/widgets/KoZoomAction.cpp<br />
libs/widgets/KoZoomAction.h<br />
libs/widgets/KoZoomController.h<br />
libs/widgets/KoZoomController_p.h<br />
libs/widgets/KoZoomHandler.cpp<br />
libs/widgets/KoZoomHandler.h<br />
libs/widgets/KoZoomInput.h<br />
libs/widgets/KoZoomMode.cpp<br />
libs/widgets/KoZoomWidget.cpp<br />
libs/widgets/KoZoomWidget.h</div></div></div><br /><div><strong>To: </strong>ognarb<br /><strong>Cc: </strong>Calligra-Devel-list, dcaliste, cochise, vandenoever<br /></div>