<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 18 February 2016 at 14:51, René J.V. <span dir="ltr"><<a href="mailto:rjvbertin@gmail.com" target="_blank">rjvbertin@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote:<br>
<br>
>>> > since QIcon::fromTheme() apaprently isn't able to find app icons.<br>
<br>
</span>Care to explain? QIcon::fromTheme() doesn't find anything "out of the box" on OS X (and I presume on MS Windows), but that is only because no theme search path is set on those platforms. When you add the standard XDG icon repository to the icon search path on OS X, even "pure" Qt5 application will start showing icons all over if you have an icon theme installed -- including in widgets that should not have icons according to the HIG.<br></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">Sure but we all agree that outside of desktops adjusted for the taste of geeks XDG isn't<br>part of these OSes. I don't plan to bundle shared theme dir or support that for users by default. I'd leave that to extensions maintained by enthusiasts :)<br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also on OS X, fromTheme() will only return the application icon (as in the icon shown in the Finder) if the current theme defines that same icon for the calling application, and the theme search path is set of course. In all other cases it will not, because the application icon is not defined through a theme on OS X (nor is it on MS Windows, I presume).<br>
<span><br>
>> I think the solution with a packaged breeze icons resource working<br>
>> out-of-the box could be a good (lightweight) addition for non-Plasma<br>
>> (non-Linux?) users of KF5, to popularize KF5. They grab the icons package<br>
<br>
</span>Popularise, with Breeze "art"work? O:-)<br></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Yes but mainly in the Qt (so also KDE) world :) I hope that making any valuable Qt app look more pro thanks to that is even better investment than popularizing GIMP and LibreOffice via that artwork before even Qt/KDE equivalents are shipped in stable on Win/Mac (Krita, Calligra).<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Anyway, I don't think "grabbing an icon package" will work on OS X, not if you want to create standalone app bundles which by definition contain everything they need.<br></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">What I mean is "grabbing an</div> <div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">icon package by software devs", not users. Adding the self-contained theme to the package would be a matter of 'a few clicks' (it's also legal becase that's combination within a media, not linking).<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
>> and icons just work without thousands of files, caching, etc. 'One in a<br>
>> million' would of these users would be interested in theming.<br>
<br>
</span>I'd up that estimate if we're still talking about Breeze icons here O:-)<br></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">I mean one instance of the icon package, that uses Breeze.<br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">Anyone is free to create similarly complete package out of other theme but this should not be a trouble for app authors. I'd propose to delegate this out of the app projects.<br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
>> PS2: I have been beaten by situations such as KToolBar setting 0-size<br>
>> icons by default.<br>
<br>
</span>Partly this is because almost no KF5 code uses the fallback argument of QIcon::fromTheme() explicitly, which means that the function returns an empty icon if the search fails.<br>
In particular, statements like<br>
<br>
app->setWindowIcon(QIcon::fromTheme(programName))<br>
<br>
should read<br>
<br>
app->setWindowIcon(QIcon::fromTheme(programName, app->windowIcon()))<br>
<span><br>
<br>
>> This is in a Windows env where no themes are (properly) installed. If the<br>
>> rcc-based solution is in use I would imagine that ideally all the KF5 code<br>
>> detects this somehow and would not look for xdg standard themes through the<br>
>> classic KIconLoader but silently adapt so the rcc resource works great.<br>
>> Just a dream.<br>
<br>
</span>If your rcc resource corresponds to the resource mentioned in the QIcon::fromTheme() documentation (I think that talks about "qrc") and if I interpret that documentation correctly then yes, code using that function will find icons from the rcc/qrc "builtin" resource over those in xdg themes (if the XDG icon repository is even in the icon theme search path).<br>
<span><br></span></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">Yes, I'll try that in the same way as Kate on win/mac. And share the results, for sure.<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
>>> What I don't know <div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div>however is whether artists consider that these icons<br>
>>> should be themeable...<div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div><br>
<br>
</span>I think icon artists will consider that you should touch their icons (for theming or anything else). They will probably also consider that their icons are the "best" but they really should also consider it a right for anyone to use other icons ;)<br>
<span><font color="#888888"><br></font></span></blockquote><div> <span><font color="#888888"><br></font></span><span style="font-family:monospace,monospace">(that </span><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace">>>> </span></div><span style="font-family:monospace,monospace">was a comment </span><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace">David :</span></div><span style="font-family:monospace,monospace">)<div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"> but I agree</div><br><br></span><span><font color="#888888"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><span style="color:rgb(0,0,0)">In short either all icons used by a given app are supported by selected theme, or theming is a waste of effort. After years I generally think theming is very special statistically a low-priority task. In most cases for Linux software if there's no single default worldwide for given app; distros change that to naturally differentiate themselves. Only web apps are immune to that because the environment they run in is consistent. <br>Then when even you, the author, do not know how your app looks on the user's desktop, even things such as documentation is hard to prepare (if it exists at all!) since it refers to one (usually even older) icon theme. <br>My favourite support request from 2016 is so far: how to find an "about app" action, because on non-Plasma desktop the help icon was completely different.<br></span><br></div>
</font></span></div></div>-- <br><div>regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a></div>
</div></div>