<div dir="ltr"><br><br>On 31 August 2015 at 10:44, Dmitry Kazakov <<a href="mailto:dimula73@gmail.com" target="_blank">dimula73@gmail.com</a>> wrote:<br>><br>><br>>> >> 2) I am personally against of automated whitespace reformatting,<br>>> >> because<br>>> >> it pollutes history of files without any use. Includes,<br>>> >> slots, forward declarations reformattings are ok. Whitespace no.<br>>> ><br>>> ><br>>> > There is a lot of use in whitespace cleanup: it makes the code<br>>> > consistent and readable.<br>>><br>>> Yes, we discussed that a bit a while ago. Initially I was critical<br>>> too. But whitespace changes can be ignored when generating diff _and_<br>>> blame (the -w option). Anyone can add this flag in git options for<br>>> diff/blame. I'd do so.<br>>><br>>> I'd like to note that we don't have a proven formatting tool for now<br>>> for all C++ elements. astyle got broken, and clang formatter can be<br>>> better but we need an expert. Missing things may be minor but we can't<br>>> make the result worse in problematic areas than the original. Not even<br>>> KF5 has a formatting tool, last I checked.<br>><br>><br>> Yes, the last time we discussed it, I raised quite a few issues with the<br>> formatter and got a response that "they are limitations of the formatter and<br>> cannot be overcome easily". So why we should spend time on it at all if it<br>> doesn't solve any real issue? At least in Krita I don't see any real problem<br>> with formatting. Yes, there are a few places where it is non-standard, but<br>> we fix it when refactoring these lines.<br><br>How about that:<br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif">A kind of the same here.Personally I can live in kexi.git without formatting
and renames for some time, in this dept non-app repos like kreport.git
deserve renames first for basic consistency (there are classes with no
prefixes, Ko prefixes and KReport prefixes, all mixed now). Because it's more like a 'public' code, headers are actually installed.<br></span></div></span><span style="font-family:arial,helvetica,sans-serif"><br></span></div><span style="font-family:arial,helvetica,sans-serif">When kexi.git and krita.git and </span><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif">(</span></div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif"></span></div><span style="font-family:arial,helvetica,sans-serif">cut-off</span><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif">)</span></div><span style="font-family:arial,helvetica,sans-serif"> calligra.git </span><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif">gets created, repo maintainers can decide with to do regarding formatting. I hope it can wait. First we're</span></div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif"> about to have some renames. Every calligra subproject has specific time frames and workforce. Let's distribute the decision....<br></span></div><br><span style="font-family:arial,helvetica,sans-serif"><div><br><span style="font-family:arial,helvetica,sans-serif">PS: Re-wrapping </span><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><span style="font-family:arial,helvetica,sans-serif">looks like the most intrusive change. git diff -w won't ignore it. Example:</span><br></div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><b>Original: one line</b></div><br><span style="font-family:monospace,monospace"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div>void FoobarClass::setFoobar(</span><span style="font-family:monospace,monospace">VeryLongType a1, VeryLongType a2, <div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"></div>VeryLongType a3)<br><br>-><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><b>Formatted: 2 lines</b></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"><b></b></div><br><br>void FoobarClass::setFoobar(</span><span style="font-family:monospace,monospace">VeryLongType a1, VeryLongType a2,<br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"> </div>VeryLongType a3)</span><br><br>-- <br>regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a></div></span></div>