<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124278/">https://git.reviewboard.kde.org/r/124278/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would really love it if it were several separate patches. Especially the patch with readability changesm which makes review quite complicated. Anyway, even after I review this, we need to ask our users to test it on various tablet devices, which can behave quite insanely.</p></pre>
<br />
<p>- Dmitry Kazakov</p>
<br />
<p>On Июль 7th, 2015, 6:31 д.п. UTC, Michael Abrahams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael Abrahams.</div>
<p style="color: grey;"><i>Updated Июль 7, 2015, 6:31 д.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=341899">341899</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch rewrites most of kis_tablet_support_win.cpp to support basic
use of the eraser key on the Surface Pro 3. The basic issue is that the
SP3 eraser button does not register being held until the stylus is
touched to the screen. A secondary issue is that the eraser button might
be pressed in the middle of the stroke, disrupting the ordinary
schedule of press and release events.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch attempts to handle those issues by watching for "inline"
cursor changes. If a packet pops up with a different cursor ID, we will
dispatch a release event and a tool switch signal. This breaks some
layers of abstraction but it seems to work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The rest of the rewrite mostly focuses on readability, but adds a few
assorted fixes elsewhere, in particular allowing the current tool to be
changed by hovering over the dockers (necessary to allow the SP3 to
set an alternate alternate tool with the eraser button), an addition to
the x11 tablet code to give the same functionality, a prescaling feature
for QTabletEvent, preventing multiple instances of the Qt/Wintab dialog,
and a few typo corrections.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/input/wintab/kis_screen_size_choice_dialog.cpp <span style="color: grey">(364419b)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support.h <span style="color: grey">(8c1b279)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support_win.cpp <span style="color: grey">(5e5d82f)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support_x11.cpp <span style="color: grey">(0e28671)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(731faed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124278/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>