<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123833/">https://git.reviewboard.kde.org/r/123833/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael Abrahams.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This refactors polygonal, elliptical, and rectangular selection tools to use a basic selection tool template. This overrides any alternate actions, although none of those tools support alternate actions and were already overriding the modifier keys to begin with. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shift: add to selection
Alt: subtract from selection
Shift+Alt: intersect current selection
Ctrl: replace selection</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Basic functionality is implemented in KisToolSelectBase, which covers the outline, contiguous, similar color and path selection tools which inherit from KisToolSelectBase. A more complete refactoring might define KisToolSelectBase via the selection tool template, but it is not simple for the path selection tool which uses a more complicated delegated design pattern.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are no tests for the selection tools in particular, but the tests for other individual tools passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeFiles/2.8.12.1/CMakeDetermineCompilerABI_CXX.bin <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/image/kis_selection.h <span style="color: grey">(6376f874)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h <span style="color: grey">(7b2cd2f)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_elliptical.cc <span style="color: grey">(999f1a0)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_path.cc <span style="color: grey">(9f1a65c)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h <span style="color: grey">(feee9cb)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc <span style="color: grey">(9acca50)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h <span style="color: grey">(5e88766)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_rectangular.cc <span style="color: grey">(331c6a4)</span></li>
<li>krita/ui/input/kis_alternate_invocation_action.h <span style="color: grey">(b47c59e)</span></li>
<li>krita/ui/input/kis_alternate_invocation_action.cpp <span style="color: grey">(48723bf)</span></li>
<li>krita/ui/tool/kis_selection_action_template.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/tool/kis_tool_paint.h <span style="color: grey">(48c1f35)</span></li>
<li>krita/ui/tool/kis_tool_polyline_base.h <span style="color: grey">(f681fd8)</span></li>
<li>krita/ui/tool/kis_tool_polyline_base.cpp <span style="color: grey">(6071f76)</span></li>
<li>krita/ui/tool/kis_tool_rectangle_base.h <span style="color: grey">(a0b470c)</span></li>
<li>krita/ui/tool/kis_tool_rectangle_base.cpp <span style="color: grey">(8e091d0)</span></li>
<li>krita/ui/tool/kis_tool_select_base.h <span style="color: grey">(500d6dd)</span></li>
<li>krita/ui/tool/kis_tool_select_base.cpp <span style="color: grey">(40779ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123833/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>