<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123498/">https://git.reviewboard.kde.org/r/123498/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 15th, 2015, 11:17 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's integrate it into the example-piggz branch for KReport.
Please note that we did not enable the map plugin in KReport. Do you want to take this task?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i decided on one more round of review due to major fixes :)</p></pre>
<br />
<p>- Adam</p>
<br />
<p>On May 17th, 2015, 3:45 p.m. UTC, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated May 17, 2015, 3:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tidied up and removed unused function
Enabled the scripting interface
Implemented the new maniupulateData interface to allow
controlling the map widget from a report script</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Requires review 123496</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added map to report
Created script to control map data from individual fields
Report renders correctly</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/common/KoReportASyncItemBase.h <span style="color: grey">(6f7e4db743f83bf7502b1637fec281b52d93cab5)</span></li>
<li>libs/koreport/common/KoReportASyncItemBase.cpp <span style="color: grey">(2949ef80ea5e939a33ff8048a2f55dec00fd2ffd)</span></li>
<li>libs/koreport/renderer/KoReportPreRenderer.cpp <span style="color: grey">(16066c530d30684460aa7dfb7801a76b25517d8f)</span></li>
<li>libs/koreport/renderer/scripting/krscriptreport.h <span style="color: grey">(326fe63507ee89ec7bd2fae0ddaf6fdaa17cab53)</span></li>
<li>libs/koreport/renderer/scripting/krscriptreport.cpp <span style="color: grey">(8fe551cad807931775ba67e1647dc832f310850c)</span></li>
<li>plugins/reporting/maps/KoReportItemMaps.h <span style="color: grey">(eb8404b8720c084e7cc174c84906c4aadecae396)</span></li>
<li>plugins/reporting/maps/KoReportItemMaps.cpp <span style="color: grey">(3aa8942d8041a224fbd8623fd97388fdd2a33584)</span></li>
<li>plugins/reporting/maps/KoReportMapsPlugin.cpp <span style="color: grey">(675fd96b6b6c335b946f90611904f1bb20b79a2f)</span></li>
<li>plugins/reporting/maps/krscriptmaps.h <span style="color: grey">(38fba1eade5f025afcf1fc8b586f646f03238456)</span></li>
<li>plugins/reporting/maps/krscriptmaps.cpp <span style="color: grey">(9fc21c7fcb94b888d8bd930fe770af787c6f759b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123498/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/0012b23c-6396-46e3-8d5c-4d6080338aae__POI.kexi">POI Database</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/02fe1f44-6159-46b4-9998-a401c885bc3a__rptPoi.pdf">What the report should look like</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>