<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123587/">https://git.reviewboard.kde.org/r/123587/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2015, 8:36 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123587/diff/3/?file=365502#file365502line58" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/renderer/scripting/krscriptconstants.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">PageNumber</span><span class="p">()</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">PageNumber</span><span class="p">()</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you remind what was the reason to use capital letter for PageNumber?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I cannot, however it is part of the user api now</p></pre>
<br />
<p>- Adam</p>
<br />
<p>On May 2nd, 2015, 9:12 p.m. UTC, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated May 2, 2015, 9:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial documentation for the KoReport user scripting system
A mainpage with a general overview
Documentation for the Report object API
All other docs auto generated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No code changes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/Doxyfile <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/KoReportScript.dox <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/Mainpage.dox <span style="color: grey">(98de42fe1b197679f74b61f5b27c4c552102cd13)</span></li>
<li>libs/koreport/items/label/krscriptlabel.h <span style="color: grey">(ade236cb24f45e826b2975a2859f1c2b6060a38b)</span></li>
<li>libs/koreport/renderer/scripting/krscriptconstants.h <span style="color: grey">(f90798d2642b87ec9a51a79a863d7128e1664901)</span></li>
<li>libs/koreport/renderer/scripting/krscriptdebug.h <span style="color: grey">(e60eac49a61faa2b4baa9b5a0ed607ecac6f62f9)</span></li>
<li>libs/koreport/renderer/scripting/krscriptdraw.h <span style="color: grey">(6fcc886539e540bba86be7e1811ee8f4fc7f7bdf)</span></li>
<li>libs/koreport/renderer/scripting/krscriptreport.h <span style="color: grey">(3b69e2f0a8e362dd1f940714c2c7d00d92b7438b)</span></li>
<li>libs/koreport/renderer/scripting/krscriptsection.h <span style="color: grey">(32fc1a9cf3679664f7062df999b8e7a7f5d425cd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123587/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/01/c3b7b571-5fa4-46e2-ac93-470ace2e3b29__scripting.png">Mainpage</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>