<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123471/">https://git.reviewboard.kde.org/r/123471/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2015, 11:36 p.m. CEST, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123471/diff/1/?file=362542#file362542line78" style="color: black; font-weight: bold; text-decoration: underline;">plugins/reporting/maps/KoReportItemMaps.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportItemMaps::createProperties()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_longitudeProperty</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">,</span> <span class="mf">0.0</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_longitudeProperty</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">,</span> <span class="mf">0.0</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"longitude"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if you fix other i18n's, i18n("longitude") -> i18n("Longitude") is worth doing</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(I just forgot it's fixed in other patch)</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On April 22nd, 2015, 10:57 p.m. CEST, Radosław Wicik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis.</div>
<div>By Radosław Wicik.</div>
<p style="color: grey;"><i>Updated April 22, 2015, 10:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kexi: MapBrowser: Improved properties for forms and reports</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.h <span style="color: grey">(d8f9da52ed8814c35b1013f909940e50cf9b2383)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp <span style="color: grey">(c86462ea5fa6663351687ab4a26c9c853b450d05)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.h <span style="color: grey">(ffaea65f0be222373ec84a93c26e96b53bd03fc1)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp <span style="color: grey">(df9ad7ea25c37a084d69019a9d4fcb6c22a11fdf)</span></li>
<li>libs/koproperty/editors/spinbox.cpp <span style="color: grey">(17638610389773174461f6ff63fcae08aa4f2d95)</span></li>
<li>plugins/reporting/maps/KoReportItemMaps.cpp <span style="color: grey">(c862655006b9f8423be48f1eafa053573dd1f06b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123471/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>