<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123226/">https://git.reviewboard.kde.org/r/123226/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Adam Pigg</p>
<br />
<p>On April 2nd, 2015, 1:05 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated April 2, 2015, 1:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345210">345210</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix logic for adding new records for Kexi tables and forms</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">- recently we allow editing to start in a row different than the current row, for this we need to remember which row is being edited, not just if the current row is edited
- the above is used by a feature that first starts editing a row (e.g. the last) and only after that moves the cursor (animations are possible this way)
- fixed buffered changes in edited record, otherwise saving did not work properly
- added sanity checks for cases when editing of a row is requested but editing of other row was not accepted/cancelled</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for 2.9.3</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with table views and form; now multiple clicking the "+ Go to new record" button in the record navigator adds multiple records as expected; any other editing works too like before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(306ffe6dfa16ed34f2f757538afdedec0520633e)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(1ea54670835e352d2f916ecbe824127d6d1db3f2)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(73fc84dfb5578a6d7752c7ea86a13127473a0879)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(0a388059222737d0d53778b703ac7f1c03b5464c)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(973d4e6ddf0fb8cd5348034f05e6d2ffa7c80897)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(2e162786aa1d8366d7480c2aa298c75988993843)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp <span style="color: grey">(55b381077e50bcc52a40f7b7cc6b2aeb338e5c4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123226/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>